incubator-flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Harui <aha...@adobe.com>
Subject Re: [jira] [Commented] (FLEX-33177) Getting Mustella mx folder to Work
Date Tue, 28 Aug 2012 22:11:06 GMT
Are you using SVN or Git to patch?  SVN doesn't take binary patches so
changes to the baselines are not taken.  When I run against the checked in
baselines I get a lot of failures and I should because the tests are wrong.
Just cutting new baselines is not the right thing to do.  Many of those
baselines should not be blank.

And then there are a set of tests in effects/Effect/seek that should be
failing because the embedAsCFF is true for the normal font yet the tests
heavily use MX components.  There should be bitmap compare differences there
as well against what is in SVN (which appears to be correct AFAICT).

So, try taking the patches to the tests but not the baselines and see what
you get.  Then if you want to submit new baselines, you will have to
convince me why the ones in SVN are wrong.


On 8/28/12 1:27 PM, "Carlos Rovira" <carlos.rovira@codeoscopic.com> wrote:

> Hi Alex,
> 
> As I stated in other thread mx is passing for me. I would want to pass
> again as I check the locale sdk construction as my system is in
> spanish locale, not as Jose that is in english locale.
> 
> Maybe your fails could be related to our location (spain)? OS is not
> the problem since we all three are in MacOSX.
> 
> Maybe Carol or Peter could test the three patches to see as well if
> they have problems...
> 
> 
> 
> 2012/8/28 Alex Harui <aharui@adobe.com>:
>> 
>> 
>> 
>> On 8/28/12 8:50 AM, "Carlos Rovira" <carlos.rovira@codeoscopic.com> wrote:
>> 
>>> Ok,
>>> 
>>> @Alex, I see that the right patches are 8,9 and 17. As well I'm
>>> downloading using curl -O <url-to-patch> and making patch -p1 < patch
>>> 
>>> I revert as well to return to a clean synced SVN state
>>> 
>>> sorry for the confusion, I will try it again the test of MX and report
>>> what I see...
>>> 
>>> 
>> I reverted and applied those 3 patches.  I got 153 failures.  Again there
>> are missing buttons in many effect tests and the fonts are wrong in many
>> others.
>> 
>> --
>> Alex Harui
>> Flex SDK Team
>> Adobe Systems, Inc.
>> http://blogs.adobe.com/aharui
>> 
> 
> 

-- 
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui


Mime
View raw message