incubator-flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Harui <aha...@adobe.com>
Subject Re: [MENTORS] Current Branching Strategy Vote Results
Date Thu, 16 Aug 2012 01:15:42 GMT



On 8/15/12 3:30 PM, "Justin Mclean" <justin@classsoftware.com> wrote:

> Hi,
> 
>> After digging for a while, it turns out that the apache.swc that
>> Justin added to trunk broke the validator tests because he added a validator
>> resource bundle there and the linker uses the first bundle found and does
>> not aggregate them so all of the other spark validator resources are missing
>> causing the tests to fail.
> 
> From memory the existing validator classes don't need or use any of the new
> resources and the new validator class were placed in a new namespace and swf
> so I wouldn't of expected them to cause any issues along these line. Without
> more info on the error I'm not 100% sure what the problem is. I can't
> currently run Mustella in my development environment because of the issues it
> has with spaces in it's path.
The explanation is above.  By adding your own validator.properties to a swc
the linker will not find the framework.swc's validator.properties and tests
relying on those resources fail.
> 
>> The quick answer is to revert that change or move the resources to the
>> central bundle in framework.swc
> The quick answer would be to fix the test would it not? Tell me what the exact
> issue is and I'll have a go a fixing it. Probably better if the resources were
> kept separate as if they are not we need localizations for every supported
> language  that framework.swc needs.
The tests are correct.  The addition of the apache.swc with its
validator.properties broke the tests.

Long term, the linker should probably try to aggregate bundles with the same
name.  Short term, we either use a different bundle name in apache.swc,
consolidate its resources into framework.swc's validator.properties, or
revert.

-- 
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui


Mime
View raw message