incubator-flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jude <flexcapaci...@gmail.com>
Subject Re: [jira] [Updated] (FLEX-33156) focusInHandler() in spark Scroller doesn't null check focusManager property before using
Date Sun, 05 Aug 2012 08:33:03 GMT
I just spent the last 3 days on this error. The solution was to have the
container of the component of the event.target (in the Scroller
focusInHandler) implement the IFocusManagerContainer. Specifically the
container needs to override the systemManager getter.

Either way we should find out what, if any negative affect this may have in
added the null check, if possible. Otherwise +1.

On Sat, Aug 4, 2012 at 5:05 AM, Roland Zwaga <roland@stackandheap.com>wrote:

> >> the super.focusHandler() implementation in UIComponent performs the
> same check,
> >> therefore I figured it would make sense here as well. Do you reckon
> otherwise?
> > Sure without tests bit hard to tell what (if any) side effect there
> might be. It looks fine to be but no way to be 100% sure. Note that
> anything to do with focus is easy to test in an automatic way. Hopefully
> the Mustella tests that should be here any day now have some tests around
> this.
>
> Hey,
>
> from what I see in the isOurFocus() method it just check if the
> event.target == this, so the event is bubbling (I suppose),
> so it performs the handler only if the event is dispatched by the
> component itself.
> But I agree that we can only be sure after running the mustella tests,
> so let's wait for that to drop.
>
> Roland
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message