incubator-flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carlos Rovira <carlos.rov...@codeoscopic.com>
Subject Re: Getting Mustella to work.
Date Thu, 23 Aug 2012 13:50:54 GMT
Ok Peter,

since I had to recreate it I was considering it derived and not needed in
VCS.

So I understand I should make a patch with png I created with -createImages
for test that already passed and send it to you for applying?

Best,

Carlos

2012/8/23 Peter Ent <pent@adobe.com>

> No, I don't think the images should be removed. Once a test has been
> created and the test author believes the test is running correctly, the
> author creates the baseline against which all other runs are judged.
> Should the code being tested change, the baseline comparison can tell if
> something is amiss. If you don't have the baseline present you would not
> know there was a test failure.
>
> At least that's how it should work, as I understand it.
>
> --peter
>
>
> On 8/23/12 9:30 AM, "Carlos Rovira" <carlos.rovira@codeoscopic.com> wrote:
>
> >Hi,
> >
> >would it be better to remove the images in baseline folders since people
> >runing test should generate it with -createImages?
> >
> >Right now I think is confusing for people entering mustella since those
> >files are commited as part of the framework but are really derived files
> >that need to be constructed the first time (moreover I will point it as a
> >required step to setup mustella and be able to run test)
> >
> >
> >2012/8/22 Alex Harui <aharui@adobe.com>
> >
> >>
> >>
> >>
> >> On 8/22/12 9:19 AM, "Carlos Rovira" <carlos.rovira@codeoscopic.com>
> >>wrote:
> >>
> >> > Many Thanks Carol, I'm taking over mustella thanks to wiki, Peter,
> >>Alex
> >> and
> >> > you little by little.
> >> > Seems that many times as you fix a problem subsequent fails dissapear.
> >> I'll
> >> > try the imageDiffAIR you say, since creteImage this time left the
> >>first
> >> > error unexpectely...
> >> >
> >> No test should really affect another, but the clean up between tests is
> >>not
> >> perfect so that can occasionally happen.  Sometimes a fix for the first
> >> test
> >> is for an asset or style that is shared by other tests.
> >>
> >> Sometimes tests have timing issues and will work on some runs and not on
> >> others.  Hopefully we will flush out and fix those tests as we go
> >>through
> >> them on this pass.  But you are also welcome to give up and comment out
> >>a
> >> flaky test on occasion.
> >>
> >> --
> >> Alex Harui
> >> Flex SDK Team
> >> Adobe Systems, Inc.
> >> http://blogs.adobe.com/aharui
> >>
> >>
> >
> >
> >--
> >Carlos Rovira
> >Director de Tecnología
> >M: +34 607 22 60 05
> >F:  +34 912 35 57 77
> ><http://www.codeoscopic.com>
> >CODEOSCOPIC S.A. <http://www.codeoscopic.com>
> >Avd. del General Perón, 32
> >Planta 10, Puertas P-Q
> >28020 Madrid
>
>


-- 
Carlos Rovira
Director de Tecnología
M: +34 607 22 60 05
F:  +34 912 35 57 77
<http://www.codeoscopic.com>
CODEOSCOPIC S.A. <http://www.codeoscopic.com>
Avd. del General Perón, 32
Planta 10, Puertas P-Q
28020 Madrid

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message