incubator-flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bertrand Delacretaz <bdelacre...@apache.org>
Subject github pull requests, ICLAs and voluntary contributions (was: Apache Flex in Github)
Date Fri, 17 Aug 2012 12:43:57 GMT
On Fri, Aug 17, 2012 at 2:29 PM, Justin Mclean <justin@classsoftware.com> wrote:
> ...I could look up your github username, see that your've made a pull request, generate
> the patch myself and then apply to SVN but that's a fair of work and more importantly
> other people don't get to see and review the patch in JIRA....

Note also two things related to that:

1) In the http://www.apache.org/licenses/icla.txt that you signed,
"You represent that each of Your Contributions is Your original
creation" - of course this doesn't apply when committing a patch
created by someone else, but in that case you have to be able to point
to that someone and to where they made their contribution.

As you say, that's much easier if the patch in question is in jira
(attached, or linked to a github pull request, doesn't really matter
IMO) - but the important part is that you must be able to point
reliably to the source of the contribution, and the simplest way is to
include a jira ID in the commit message ("contributed for Foo
Barzinsky as part of FLEX-1234"). I assume Apache Flex wants to track
what's being done via jira issues anyway, at least for non-trivial
commits.

2) The ASF only accepts voluntary contributions, so you cannot go
hunting yourself for Flex patches on github on somewhere else, it's
the contribution's author who has to actively indicate (on this list
or in jira for example) what they mean to contribute.

http://wiki.apache.org/couchdb/CommitPolicy has additional info about
this (and http://wiki.apache.org/couchdb/ContributorWorkflow but
that's for an Apache project that's already using Git as their main
ASF repository).

-Bertrand

Mime
View raw message