incubator-flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Roland Zwaga <rol...@stackandheap.com>
Subject Re: [jira] [Updated] (FLEX-33156) focusInHandler() in spark Scroller doesn't null check focusManager property before using
Date Sat, 04 Aug 2012 10:05:09 GMT
>> the super.focusHandler() implementation in UIComponent performs the same check,
>> therefore I figured it would make sense here as well. Do you reckon otherwise?
> Sure without tests bit hard to tell what (if any) side effect there might be. It looks
fine to be but no way to be 100% sure. Note that anything to do with focus is easy to test
in an automatic way. Hopefully the Mustella tests that should be here any day now have some
tests around this.

Hey,

from what I see in the isOurFocus() method it just check if the
event.target == this, so the event is bubbling (I suppose),
so it performs the handler only if the event is dispatched by the
component itself.
But I agree that we can only be sure after running the mustella tests,
so let's wait for that to drop.

Roland

Mime
View raw message