incubator-flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: [jira] [Updated] (FLEX-33156) focusInHandler() in spark Scroller doesn't null check focusManager property before using
Date Sat, 04 Aug 2012 07:14:07 GMT
Hi,

> the super.focusHandler() implementation in UIComponent performs the same check,
> therefore I figured it would make sense here as well. Do you reckon otherwise?
Sure without tests bit hard to tell what (if any) side effect there might be. It looks fine
to be but no way to be 100% sure. Note that anything to do with focus is easy to test in an
automatic way. Hopefully the Mustella tests that should be here any day now have some tests
around this.

Thanks,
Justin
Mime
View raw message