incubator-flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carol Frampton <cfram...@adobe.com>
Subject Re: Compiling SDK for other locales and versions of the Flash Player
Date Mon, 23 Jul 2012 19:21:18 GMT


On 7/23/12 11 :15AM, "Justin Mclean" <justin@classsoftware.com> wrote:

>Hi,
>
>I've just checked in changes to the build scrips that will:
>
>1. Enable you to compile the SDK for locales other than eu_US. All of the
>locales supported in 4.6 are supported with the addition of en_AU
>(Australian), en_GB (British) and en_CA (Canadian). el_GR (Greek) is just
>waiting on a few files. To change the locale you wish to compile the SDK
>for just change the value of locale (currently line 29 and set to
>"en_US") in build.properties.
>
>2. Allow you to compile the SDK for any version of the Flash Player from
>10.2 to 11.4. Extensive testing has not been carried out on versions
>other than 11.1 (waiting on Mustella tests to be donated) but from my own
>informal testing it runs quicker on 11.2 and 11.3 and I've not seen any
>issues. Mobile application may have performance or other issues on
>earlier versions of the Flash Player before 11.1.
>
>Feedback on the changes is welcome.

Hi Justin,

I just took a look at the submits.

* The change spans 6 commits.  Is there some reason you didn't combine
them since all the changes were related to one "feature"?
* I would have preferred that you renamed flex-config.xml to
flex-config-template.xml so I could have easily seen what you changed and
the version history was preserved.
* flex-config now has @locale@ and {locale}.  I think your change has made
{locale} obsolete since @locale@ could be used instead. Then the compiler
wouldn't have do the scan and make the substitution for each file compiled.
* build_framework.xml doesn't really need the property def for locale
since it is set in build.properties. In fact, it gives the false
impression that setting it will change the locale which isn't the case
anymore.
* I'm a bit concerned that the format of <name> in
flex-sdk-description.xml changed.  I know FlashBuilder looks at that.
I'll have to test the current and preview release for the next version.
* Thanks for fixing {$locale}.

Carol


Mime
View raw message