incubator-flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jude <flexcapaci...@gmail.com>
Subject Re: [DISCUSS] Make EffectManager effects property public
Date Mon, 25 Jun 2012 16:48:09 GMT
How much freedom do we have? Marking it public is fine, using a getter is
fine, adding a setter is fine as well.

What about adding the effect instances to the effectsPlaying property on
EffectManager.effectStart() method? Would that have any adverse effect? If
it did we could refactor effectsPlaying to triggerEffectsPlaying and use
effectsPlaying for normal effects (or normal and trigger) so the names
matche the descriptions.

We could also dispatch an effectStart and effectEnd event from the
EffectManager class. Doing both would solve the problem of tracking
effects.

On Sun, Jun 24, 2012 at 7:33 AM, Justin Mclean <justin@classsoftware.com>wrote:

> Hi,
>
> > Agreed, a read-only property sounds safer. Even though it would still
> allow
> > outside parties to add or remove keys.
>
> You could add a method/setter that makes a copy of the dictionary. The
> AdvancedDataGriud columns getter does this (array rather than dictionary
> but basically the same thing).
>
> Justin

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message