incubator-flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Om <bigosma...@gmail.com>
Subject Re: [jira] [Commented] (FLEX-61) AIR version of makeApacheFlexForFlashBuilder for Windows
Date Thu, 24 May 2012 21:37:36 GMT
Carol,


> After it finished downloading the AIR SDK for Mac I got this but I didn't
> debug it.
>
> Downloaded 100%
> Native Process not supported unable to untar Adobe AIR SDK
> MakeApacheFlexForFlashBuilder invoked in GUI mode
>

You probably dont have the latest version of
MakeApacheFlexForFlashBuilder-app.xml.  I might have messed it up during
the merge process.  Please look inside and make sure that line 119 looks
like this:
<supportedProfiles>extendedDesktop</supportedProfiles>


- Someone needs to write an ant script to build this project.
>

I will work on it.

- There is a minor error in the comment. It should be "Flash Builder" not
> "Flash Player".  Chris corrected it for me in my scripts.
>

Fixed.

I'm not sure what Apache thinks about @author.  I haven't seen it in my
> travels thru Apache code.  Personally I prefer it not be there.  If a
> committer submits the code for you they should attribute the code to you
> in the submit comment.
>

No problem, I have removed the @author attribution line.

You have inconsistent bracketing.  If we're going with maintaining the
> current style, which would be my vote, the brackets should be on a new
> line.  Regardless, the same style should be used throughout a file.
>

It was my style and Justin's style mixed in.  Fixed now as per
Justin's/Flex code style guidelines (I feel dirty, but I'll take one for
the team :-) ).

Thanks,
Om

On Thu, May 24, 2012 at 1:57 PM, Carol Frampton <cframpto@adobe.com> wrote:

>
>
> On 5/24/12 2 :50PM, "Om" <bigosmallm@gmail.com> wrote:
>
> >Justin, you changes work perfectly fine on Windows.  Sudhir, thanks for
> >confirming that it works on Macs as well.
> >
> >I have merged all the changes into here:
> >https://github.com/bigosmallm/MakeApacheFlexForFlashBuilder
> >
> >I believe at this point, we are ready to bring this app into SVN.  I dont
> >have commit permissions, can one of the committers take it up?
>
> After it finished downloading the AIR SDK for Mac I got this but I didn't
> debug it.
>
> Downloaded 100%
> Native Process not supported unable to untar Adobe AIR SDK
> MakeApacheFlexForFlashBuilder invoked in GUI mode
>
>
> In terms of committing the code
>
> - Someone needs to write an ant script to build this project.
> - There is a minor error in the comment. It should be "Flash Builder" not
> "Flash Player".  Chris corrected it for me in my scripts.
> - I'm not sure what Apache thinks about @author.  I haven't seen it in my
> travels thru Apache code.  Personally I prefer it not be there.  If a
> committer submits the code for you they should attribute the code to you
> in the submit comment.
> - You have inconsistent bracketing.  If we're going with maintaining the
> current style, which would be my vote, the brackets should be on a new
> line.  Regardless, the same style should be used throughout a file.
>
> Carol
>
>
> >
> >Thanks,
> >Om
> >
> >On Thu, May 24, 2012 at 5:37 AM, Sudhir Manjunath <sudhirm@adobe.com>
> >wrote:
> >
> >> I checked this on my MAC 10.6, and it works for me now. Thanks, Justin
> >>
> >> -Sudhir
> >>
> >> -----Original Message-----
> >> From: Justin Mclean [mailto:justin@classsoftware.com]
> >> Sent: Thursday, May 24, 2012 7:17 AM
> >> To: flex-dev@incubator.apache.org
> >> Subject: Re: [jira] [Commented] (FLEX-61) AIR version of
> >> makeApacheFlexForFlashBuilder for Windows
> >>
> >> Hi,
> >>
> >> >>> Any luck on the invoking tar from the app on a Mac?
> >> >> I took a quick look and should be able to sort it out today.
> >>
> >> Just put up code (and pull request) that should work or be very close to
> >> working.
> >>
> >> https://github.com/justinmclean/MakeApacheFlexForFlashBuilder
> >>
> >> Thanks,
> >> Justin
> >>
> >>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message