incubator-flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Sivokon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLEX-38) Build script requires sh on Windows
Date Fri, 04 May 2012 20:16:50 GMT

    [ https://issues.apache.org/jira/browse/FLEX-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268677#comment-13268677
] 

Oleg Sivokon commented on FLEX-38:
----------------------------------

This is sort of a reminder:


+<<<<<<< .mine
+       <exec executable="tar">
+         <arg value="-xjf"/>
+         <arg value="${FLEX_HOME}/in/air/mac/AIR Integration Kit.tbz2"/>
+       </exec>
+=======
         <!-- Expand the Mac AIK on top of the SDK -->
+        <!-- Note: any symlinks in this package will be lost since ant tar doesn't support
them. -->
         <copy file="${FLEX_HOME}/in/air/mac/AIR Integration Kit.tbz2" todir="${FLEX_HOME}"
verbose="true"/>
         <echo file="${FLEX_HOME}/air_unzip.sh">#!/bin/sh
 tar -xjf "AIR Integration Kit.tbz2" 
@@ -232,23 +276,41 @@
         </exec>
         <delete file="${FLEX_HOME}/air_unzip.sh"/>
         <delete file="${FLEX_HOME}/AIR Integration Kit.tbz2"/>
+>>>>>>> .r1334140

Please don't call sh like that - it doesn't do what you think it does on Linux. Also, you
don't need to copy the archive, tar will untar into current directory, not the archive directory
(this will win you some time, especially if you are doing this under Cygwin because the archive
is huge and copying it takes time).

Besides, the comment about symlinks is wrong - they would've been lost if you used Ant's <unbzip>
task, but they aren't lost with the present code.
                
> Build script requires sh on Windows
> -----------------------------------
>
>                 Key: FLEX-38
>                 URL: https://issues.apache.org/jira/browse/FLEX-38
>             Project: Apache Flex
>          Issue Type: Bug
>         Environment: Windows
>            Reporter: Oleg Sivokon
>            Assignee: Carol Frampton
>              Labels: Build,Ant
>         Attachments: build.patch, build.patch
>
>
> There is a call to sh with automatically generated shell script that was used to untar
the AIR archive. On Windows it wouldn't work and on Linux it would unpack with the permissions
given to the user of the terminal, rather then the permissions given to Ant user (files created
would be protected for Ant script later).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message