incubator-flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Sivokon (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLEX-38) Build script requires sh on Windows
Date Thu, 05 Apr 2012 11:23:22 GMT

    [ https://issues.apache.org/jira/browse/FLEX-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247153#comment-13247153
] 

Oleg Sivokon commented on FLEX-38:
----------------------------------

I'd still remove the call to sh.

It's not uncommon (on the contrary, it's very common) to alias sh to run it with some options
other than of your "normal" user, besides, it's really redundant to call sh only to call tar
afterwards. You don't need to copy the archive too because tar will untar into the current
directory from whatever directory the file is in.

I would really need to check if isWindows will be true in Cygwin.

<property environment="env"/>
<property name="is${env.OSTYPE}" value="true"/>

<target name="cygCheck" if="iscygwin">
<echo message="Running under Cygwin"/>
</target>

This would be a better way to find out what OS the script runs in. It's possibly better to
treat cygwin users as if they were on *nix, if possible... well, I guess.
                
> Build script requires sh on Windows
> -----------------------------------
>
>                 Key: FLEX-38
>                 URL: https://issues.apache.org/jira/browse/FLEX-38
>             Project: Apache Flex
>          Issue Type: Bug
>         Environment: Windows
>            Reporter: Oleg Sivokon
>            Assignee: Carol Frampton
>              Labels: Build,Ant
>         Attachments: build.patch, build.patch
>
>
> There is a call to sh with automatically generated shell script that was used to untar
the AIR archive. On Windows it wouldn't work and on Linux it would unpack with the permissions
given to the user of the terminal, rather then the permissions given to Ant user (files created
would be protected for Ant script later).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message