Return-Path: X-Original-To: apmail-incubator-flex-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-flex-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5127A996C for ; Tue, 13 Mar 2012 13:41:59 +0000 (UTC) Received: (qmail 62172 invoked by uid 500); 13 Mar 2012 13:41:58 -0000 Delivered-To: apmail-incubator-flex-dev-archive@incubator.apache.org Received: (qmail 62142 invoked by uid 500); 13 Mar 2012 13:41:58 -0000 Mailing-List: contact flex-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: flex-dev@incubator.apache.org Delivered-To: mailing list flex-dev@incubator.apache.org Received: (qmail 62134 invoked by uid 99); 13 Mar 2012 13:41:58 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Mar 2012 13:41:58 +0000 X-ASF-Spam-Status: No, hits=0.7 required=5.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [66.63.181.70] (HELO mail.controlserveronline.com) (66.63.181.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Mar 2012 13:41:50 +0000 Received: by mail.controlserveronline.com via HTTP; Tue, 13 Mar 2012 06:40:22 -0700 From: "Rui Silva" To: Subject: Portuguese postcode validator update Date: Tue, 13 Mar 2012 06:40:22 -0700 Reply-To: flex@rduartes.net Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Originating-IP: [195.23.102.124] X-Virus-Checked: Checked by ClamAV on apache.org Hi Justin, I made a couple of changes to your PostCodeValidator class in order for it to "understand" Portuguese postcodes. I've also updated the unit tests to include Portuguese postcode. Do you want me to send in a patch or is it OK if I just commit the code to your whiteboard? I also wanted to ask you why do you use assertTrue instead of assertEquals when comparing results against a constant? I prefer to use assertEquals because the fail message is more descriptive, but you might have a very good reason to use assertTrue. Just asking. Thanks, Rui