Return-Path: X-Original-To: apmail-incubator-flex-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-flex-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2009391A0 for ; Mon, 26 Mar 2012 18:51:42 +0000 (UTC) Received: (qmail 12223 invoked by uid 500); 26 Mar 2012 18:51:41 -0000 Delivered-To: apmail-incubator-flex-dev-archive@incubator.apache.org Received: (qmail 12186 invoked by uid 500); 26 Mar 2012 18:51:41 -0000 Mailing-List: contact flex-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: flex-dev@incubator.apache.org Delivered-To: mailing list flex-dev@incubator.apache.org Received: (qmail 12178 invoked by uid 99); 26 Mar 2012 18:51:41 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Mar 2012 18:51:41 +0000 X-ASF-Spam-Status: No, hits=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of aharui@adobe.com designates 64.18.1.189 as permitted sender) Received: from [64.18.1.189] (HELO exprod6og105.obsmtp.com) (64.18.1.189) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Mar 2012 18:51:31 +0000 Received: from outbound-smtp-2.corp.adobe.com ([193.104.215.16]) by exprod6ob105.postini.com ([64.18.5.12]) with SMTP ID DSNKT3C6nYQNRBjWqYes43Z+ULfYf/42EK1j@postini.com; Mon, 26 Mar 2012 11:51:10 PDT Received: from inner-relay-1.corp.adobe.com (inner-relay-1.sea.adobe.com [153.32.1.51]) by outbound-smtp-2.corp.adobe.com (8.12.10/8.12.10) with ESMTP id q2QIp7vq029070 for ; Mon, 26 Mar 2012 11:51:08 -0700 (PDT) Received: from nacas02.corp.adobe.com (nacas02.corp.adobe.com [10.8.189.100]) by inner-relay-1.corp.adobe.com (8.12.10/8.12.10) with ESMTP id q2QIp6MM016506 for ; Mon, 26 Mar 2012 11:51:06 -0700 (PDT) Received: from SJ1SWM219.corp.adobe.com (10.5.77.61) by nacas02.corp.adobe.com (10.8.189.100) with Microsoft SMTP Server (TLS) id 8.3.192.1; Mon, 26 Mar 2012 11:51:06 -0700 Received: from NAMBX02.corp.adobe.com ([10.8.127.96]) by SJ1SWM219.corp.adobe.com ([fe80::d55c:7209:7a34:fcf7%12]) with mapi; Mon, 26 Mar 2012 11:51:06 -0700 From: Alex Harui To: "flex-dev@incubator.apache.org" Date: Mon, 26 Mar 2012 11:51:04 -0700 Subject: Re: minor Validator improvement Thread-Topic: minor Validator improvement Thread-Index: Ac0LZ9K/Mkq1tPkUTm+sGGSSV/StHQAGZJzj Message-ID: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-Entourage/13.11.0.110726 acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 On 3/26/12 8:46 AM, "Omar Gonzalez" wrote: > It sounds like a good idea, my only concern is breaking a bunch of apps > that are expecting Validator.validateAll() to return a plain Array. I kno= w > there are some methods that were added, instead of changed, to return > Vectors as opposed to Arrays and not break existing apps. I can't think o= f > the method name I'm remembering, but I think its one of the display objec= ts > that changed. Anyhow, not sure what our approach should be for these kind > of changes. Adobe didn't care if we broke an app if it was for the "greater good". And we didn't convert Arrays to Vectors everywhere. So I don't think there can be a universal policy. It has to be considered for each case because there are trade-offs. If the array is passed across a MarshallPlan boundary, the= n I wouldn't change it. If the array is likely to be passed back to the server, then I wouldn't change it as it might screw up AMF serialization. If the array is a vector of "anything" then I would be cautious. BTW, I don't think it was necessary to fill out a JIRA issue. We're supposed to be watching commit emails and Jeff starting this discussion should be good enough. --=20 Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui