Return-Path: X-Original-To: apmail-incubator-flex-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-flex-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 49E3897D6 for ; Mon, 12 Mar 2012 15:02:53 +0000 (UTC) Received: (qmail 9030 invoked by uid 500); 12 Mar 2012 15:02:52 -0000 Delivered-To: apmail-incubator-flex-dev-archive@incubator.apache.org Received: (qmail 8993 invoked by uid 500); 12 Mar 2012 15:02:52 -0000 Mailing-List: contact flex-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: flex-dev@incubator.apache.org Delivered-To: mailing list flex-dev@incubator.apache.org Received: (qmail 8985 invoked by uid 99); 12 Mar 2012 15:02:52 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Mar 2012 15:02:52 +0000 X-ASF-Spam-Status: No, hits=-1.3 required=5.0 tests=FRT_ADOBE2,RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of cframpto@adobe.com designates 64.18.1.191 as permitted sender) Received: from [64.18.1.191] (HELO exprod6og106.obsmtp.com) (64.18.1.191) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Mar 2012 15:02:43 +0000 Received: from outbound-smtp-2.corp.adobe.com ([193.104.215.16]) by exprod6ob106.postini.com ([64.18.5.12]) with SMTP ID DSNKT14P/jiCAQdF6ceqakil6ok7vUWa6v8d@postini.com; Mon, 12 Mar 2012 08:02:23 PDT Received: from inner-relay-1.corp.adobe.com (inner-relay-1.corp.adobe.com [153.32.1.51]) by outbound-smtp-2.corp.adobe.com (8.12.10/8.12.10) with ESMTP id q2CF2Lvq024458 for ; Mon, 12 Mar 2012 08:02:21 -0700 (PDT) Received: from nahub02.corp.adobe.com (nahub02.corp.adobe.com [10.8.189.98]) by inner-relay-1.corp.adobe.com (8.12.10/8.12.10) with ESMTP id q2CF2IMR022413 for ; Mon, 12 Mar 2012 08:02:20 -0700 (PDT) Received: from nambx09.corp.adobe.com ([10.8.189.47]) by nahub02.corp.adobe.com ([10.8.189.98]) with mapi; Mon, 12 Mar 2012 08:01:16 -0700 From: Carol Frampton To: "flex-dev@incubator.apache.org" Date: Mon, 12 Mar 2012 08:01:15 -0700 Subject: Re: [MENTOR] question about code donation - modified code with Apache license Thread-Topic: [MENTOR] question about code donation - modified code with Apache license Thread-Index: Ac0AYPiqcSfRqUKGSxe02jctBDedQw== Message-ID: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.14.0.111121 acceptlanguage: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org On 3/12/12 10 :49AM, "Greg Reddin" wrote: >On Mon, Mar 12, 2012 at 9:44 AM, Carol Frampton >wrote: >> When donating Flex code, should the batik directory include all of the >>batik 1.6 source files with the modification applied, or should it just >>include the files that were modified? If the later the build would have >>to download the distro, unzip it, apply the modification and the build >>the jar. > >I would include all of the source files so it's easier for us to see >exactly what we have. I think this is the preferred method as well but it is a bit harder to figure out the diffs from the original although a README would help. > >> In either case, is it okay to add the build jar file to svn so that it >>doesn=B9t have to be rebuilt? When and if the sources are ever modified >>again the jar can be updated. > >Maybe I'm misunderstanding, but I think I'd rather see the source >added with build instructions, than a binary. The sources to build the jar will be in svn. I was just trying to avoid having to build the jar every build since it hasn't changed in 3 years. Carol