Mailing-List: contact flex-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: flex-dev@incubator.apache.org
Received-SPF: neutral (nike.apache.org: local policy)
From: Justin Mclean <justin@classsoftware.com>
Mime-Version: 1.0 (Apple Message framework v1257)
Content-Type: multipart/alternative;
 boundary="Apple-Mail=_5A3DA1DC-2203-4E31-9EBB-FBEAD6430EFB"
Subject: Re: [Proposal] Add PostCodeValidator and PostCodeFormatter to the SDK
Date: Sun, 11 Mar 2012 13:27:10 +1100
In-Reply-To: 
 <CAEFz_vvjxyehDjbV2pW+NuNqSUyN1xV+VYR=RG-E2dKDxrLQ_A@mail.gmail.com>
To: flex-dev@incubator.apache.org
References: <503131DD-2947-4AF1-9815-DD4CFF6B028A@classsoftware.com>
 <1331309633.52878.YahooMailNeo@web110414.mail.gq1.yahoo.com>
 <4F5A5A44.20209@leichtgewicht.at>
 <FD189E1D-CFFC-4A1B-959F-D888371A4A56@classsoftware.com>
 <4F5AABD9.9060807@leichtgewicht.at>
 <01A4F49D-376D-4F38-BE8E-AEAC71A475BB@classsoftware.com>
 <4F5B2605.5070507@leichtgewicht.at>
 <3E4447FA-4E2C-4D52-AFB3-49916D8A679C@classsoftware.com>
 <CAEFz_vvjxyehDjbV2pW+NuNqSUyN1xV+VYR=RG-E2dKDxrLQ_A@mail.gmail.com>
Message-Id: <7CF8459E-7172-4488-9B67-BD618171D602@classsoftware.com>

--Apple-Mail=_5A3DA1DC-2203-4E31-9EBB-FBEAD6430EFB
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=iso-8859-1

 Hi,

> What is the 1.5? We should try and not use any magic numbers/strings.

A few lines above is the following comment.
 // We want invalid char and invalid format errors to show in preference
// so give wrong length errors a higher value

Re magic number string I agree in general but in this case my reasoning =
at the time was not to as:
1. It totally internal to that one function
2. It's only used in one place and I can't see the potential for it to =
be used elsewhere=20
3. It actually value is meaningless (just has to >1 and <2)

It is possible that this  would be a tiny bit clearer.
Number(invalidFormat) + Number(invalidChar) + Number(incorrectFormat) + =
Number(wrongLength) * IMPORTANT_ERROR

If you look at the other validators they have hard coded strings and =
values all over the place. This code is most likely of a higher standard =
that what already exists in the Flex SDK both as originally submitted =
and with all the changes based on feedback.

If it really offends anyone that much please submit a patch :-) And =
don't forget to run the unit tests!

Thanks,
Justin=

--Apple-Mail=_5A3DA1DC-2203-4E31-9EBB-FBEAD6430EFB--