incubator-flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carol Frampton <cfram...@adobe.com>
Subject Re: referencing JIRA issues in code
Date Thu, 01 Mar 2012 15:06:17 GMT
Adobe used a checkin template that looked like:

QE notes: 
Doc notes: 
Bugs: 
Reviewer: 
Tests run: 
Is noteworthy for integration:


The checkin comment would go above the template items.  It is the file
checkin-note-template.txt in the source tree at root which we haven't
contributed yet.

We would also get email for every commit which had a Ticket Links section
which had links you could click for the JIRA issues.  I think it looked
for SDK-99999 in the comments.

Carol

On 2/29/12 11 :19PM, "Rafael Santos" <rsantos@spectacompany.com.br> wrote:

>Another interesting link related to SVN pre-commit to hook to JIRA
>https://studio.plugins.atlassian.com/wiki/display/SVN/Subversion+JIRA+plug
>in
>
>Rafael Santos - Specta
>
>
>On Thu, Mar 1, 2012 at 01:16, Rafael Santos
><rsantos@spectacompany.com.br>wrote:
>
>> Isnt it possible to relate SVN and JIRA in the commit comment?
>>
>> That is very usefull for backtracking....
>>
>> Maybe use pre-commit scripts that forbid svn commits that don't refer
>>to a
>> JIRA issue...
>>
>>
>> 
>>https://studio.plugins.atlassian.com/wiki/display/CMMT/JIRA+Commit+Accept
>>ance
>>
>>
>> Rafael Santos - Specta
>>
>>
>> On Wed, Feb 29, 2012 at 11:11, Rui Silva <flex@rduartes.net> wrote:
>>
>>> I agree with Carol. No bug numbers in code except where the solution
>>>is so
>>> complex or so awkward that it requires some background (possibly
>>> attachments and discussion thread from the JIRA issue.
>>>
>>> Rui
>>>
>>> -------- Original Message --------
>>> > From: "Carol Frampton" <cframpto@adobe.com>
>>> > Sent: segunda-feira, 27 de Fevereiro de 2012 15:16
>>> > To: "flex-dev@incubator.apache.org" <flex-dev@incubator.apache.org>
>>> > Subject: Re: referencing JIRA issues in code
>>> >
>>> > I really dislike bug numbers in the code.  As other said the svn
>>>history
>>> > is there.  The only time where it might be ok is if it is a very
>>>complex
>>> > issue which needs lots and lots of explanation and you don't want to
>>> > clutter the code with a comment with that much detail.  You should
>>>still
>>> > put in a summary comment with the bug number, in this format:
>>>[FLEX-99].
>>> >
>>> > Carol
>>> >
>>> > On 2/27/12 3 :03AM, "Alex Harui" <aharui@adobe.com> wrote:
>>> >
>>> > >
>>> > >
>>> > >
>>> > >On 2/26/12 2:32 PM, "Justin Mclean" <justin@classsoftware.com>
>>>wrote:
>>> > >
>>> > >> Hi,
>>> > >>
>>> > >> Just wondering what the policy should be on referencing JIRA
>>>issues
>>> in
>>> > >>code
>>> > >> comments
>>> > >>
>>> > >> Do we:
>>> > >> 1. Don't need to do it as it's contained in the SVN history
>>> > >>
>>> > >Adobe policy was not to put bug numbers in the code.  I believe
>>>there
>>> are
>>> > >some exceptions though.
>>> > >
>>> > >--
>>> > >Alex Harui
>>> > >Flex SDK Team
>>> > >Adobe Systems, Inc.
>>> > >http://blogs.adobe.com/aharui
>>> > >
>>>
>>>
>>>
>>


Mime
View raw message