Mailing-List: contact flex-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: flex-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of cframpto@adobe.com designates
 64.18.1.181 as permitted sender)
From: Carol Frampton <cframpto@adobe.com>
To: "flex-dev@incubator.apache.org" <flex-dev@incubator.apache.org>
Date: Fri, 24 Feb 2012 14:25:38 -0800
Subject: Re: [CODE] Short cleanup
Thread-Topic: [CODE] Short cleanup
Thread-Index: AczzQz02fKE+DELeTwyr+E9sXF7f+A==
Message-ID: <CB6D77FA.C572%cframpto@adobe.com>
In-Reply-To: 
 <CACK5iZdfyDGh0ADmgCo3s0ROeE7m6abidTcLjz6HBjXV1QjYtQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: Microsoft-MacOutlook/14.14.0.111121
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

I don't like this approach.  The replaced tag will surely get submitted.

I really don't understand why so much attention has been devoted to this
today.  There are so many other things to do.

Carol

On 2/24/12 5 :19PM, "Om" <bigosmallm@gmail.com> wrote:

>I like this approach.  This is how we bake in application version numbers,
>build timestamp, etc. while compiling release builds of Flex apps we ship.
>
>
>
>> Minor issue with this is that now the Version.as files are out of sync
>> with SVN, could accidentally be checked back in with wrong version
>>numbers
>> or the like.
>>
>> I guess there's the more philosophical  question of do we really want
>>ANT
>> scripts that modify the source code?
>>
>
>We can revert Version.as to its original state after compiling or just not
>check in the changed Version.as.  A carefully constructed build script
>should do the trick.  This way we don't really care if Ant is making
>changes to the source code.
>
>Om
>
>On Fri, Feb 24, 2012 at 2:11 PM, Justin Mclean
><justin@classsoftware.com>wrote:
>
>> Hi,
>>
>> ANT can do this quite easily.
>>
>> If we change all Version.as files to be like so:
>> mx_internal static const VERSION:String =3D "@release@";
>>
>> Then this target will inject the version number into all Version.as
>>files:
>> <target name=3D"setFlexSDKVersion">
>>        <replace dir=3D"${basedir}" includes=3D"**/Version.as"
>>token=3D"@release@"
>> value=3D"${release.version}.${build.number}" />
>> </target>
>>
>> We have these currently in the build file:
>> <property name=3D"release.version" value=3D"4.6.0"/>
>> <property name=3D"build.number" value=3D"0"/>
>>
>> So that would replace every occurrence of "@release@" with "4.6.0.0".
>>
>> Minor issue with this is that now the Version.as files are out of sync
>> with SVN, could accidentally be checked back in with wrong version
>>numbers
>> or the like.
>>
>> I guess there's the more philosophical  question of do we really want
>>ANT
>> scripts that modify the source code?
>>
>> Justin
>>
>>
>>
>>