Mailing-List: contact flex-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: flex-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of olegsivokon@gmail.com
 designates 209.85.210.175 as permitted sender)
Received-SPF: pass (google.com: domain of olegsivokon@gmail.com designates
 10.43.44.69 as permitted sender) client-ip=10.43.44.69;
MIME-Version: 1.0
In-Reply-To: <4F4752BB.20204@leichtgewicht.at>
References: <CB6C8408.3C88F%aharui@adobe.com>
	<4F4752BB.20204@leichtgewicht.at>
Date: Fri, 24 Feb 2012 13:09:37 +0200
Message-ID: 
 <CAJQBtg=SHjMcSb1Lm53GMUe_na2Gwf1VTB5BGkWSqT8knw0vMA@mail.gmail.com>
Subject: Re: [CODE] Short cleanup
From: Left Right <olegsivokon@gmail.com>
To: flex-dev@incubator.apache.org
Content-Type: multipart/alternative; boundary=bcaec52e5f89e2941b04b9b3cb5b

--bcaec52e5f89e2941b04b9b3cb5b
Content-Type: text/plain; charset=ISO-8859-1

OMG!!! Seriously, you are writing SDK code and you don't know what's the
difference between using `in' operator and calling a method defined on
Object.prototype is?

First of all, they are testing for different things. `in' is testing for a
key in a collection, key may or may not be a property, for example, a key
in the Dictionary is not a property. Object.prototype.hasOwnProperty() is a
slow to resolve and slow to execute function that will resolve the property
(which involves verifying access permissions and whether the enumeration of
the property is allowed). It is on average 4 times slower then `in' if it
is used to do the same thing.

Further more, whilst `in' has several legitimate use cases (such as
verifying whether the collection contains the key),
Object.prototype.hasOwnProperty() is usually an indication that you are
doing something wrong. For example, you did not define an interface to
abstract different object types for similar access, or you created a blob
class, you don't want to import because of too many dependencies - modular
architecture failure.
Further more, it isn't safe to use this function in mission-critical code,
because someone can easily redefine it for __every__ object in the project,
since it's defined on the prototype, and by redefining it may intercept
some of your data you passed to this function.

--bcaec52e5f89e2941b04b9b3cb5b--