incubator-flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Harui (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLEX-19) Code style improvements in framework
Date Sat, 25 Feb 2012 17:05:48 GMT

    [ https://issues.apache.org/jira/browse/FLEX-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216499#comment-13216499
] 

Alex Harui commented on FLEX-19:
--------------------------------

Regarding D: That's a pretty strict definition of backward compatibility.  I probably would've
just clipped those lines out.  In theory, the order in which properties are read shouldn't
really matter, and in this constrained environment, if you're going to bother to clean up
unused locals, you could save these bytes as well, but I could go either way.
                
> Code style improvements in framework
> ------------------------------------
>
>                 Key: FLEX-19
>                 URL: https://issues.apache.org/jira/browse/FLEX-19
>             Project: Apache Flex
>          Issue Type: Improvement
>            Reporter: Martin Heidegger
>            Assignee: Bertrand Delacretaz
>            Priority: Trivial
>         Attachments: A-semicolon.patch, B-nullboolean.patch, C-unusedimports.patch, D-unusedlocalvariables.patch,
E-returntovoid.patch, F-dynamicKeyInVariable.patch, G-unusedprivatemethods.patch
>
>
> After skimming the "framework" sub-project I created a set of patches to the source code
of various categories.
>   A) Missing semicolons in the code
>   B) Changed implict casting from object to boolean to a explicit != null
>   C) Removed unused imports
>   D) Removed local variables that are unused and arguments of private functions that
are unused
>   E) Removed return statement in functions with : void signature
>   F) Changed variables named "dynamic" to a name that is not same as a keyword
>   G) Removed unused private methods

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message