incubator-flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Heidegger (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLEX-19) Code style improvements in framework
Date Sat, 25 Feb 2012 17:15:48 GMT

    [ https://issues.apache.org/jira/browse/FLEX-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216502#comment-13216502
] 

Martin Heidegger commented on FLEX-19:
--------------------------------------

I was gunning for non-destructive improvements that keep the backwards compatibility 100%
given as there is no Mustella I could test against. Also I have no idea what the policy to
backwards compatibility policy is.

Those empty spaces slipped in - I didn't search for them :) I bet there are more missing.
I think the tabs/spaces cleanup should be done right after the final contribution from adobe.
The longer we wait the more branches will have troubles with that (merging in files where
the tabs were corrected is terrifying).
                
> Code style improvements in framework
> ------------------------------------
>
>                 Key: FLEX-19
>                 URL: https://issues.apache.org/jira/browse/FLEX-19
>             Project: Apache Flex
>          Issue Type: Improvement
>            Reporter: Martin Heidegger
>            Assignee: Bertrand Delacretaz
>            Priority: Trivial
>         Attachments: A-semicolon.patch, B-nullboolean.patch, C-unusedimports.patch, D-unusedlocalvariables.patch,
E-returntovoid.patch, F-dynamicKeyInVariable.patch, G-unusedprivatemethods.patch
>
>
> After skimming the "framework" sub-project I created a set of patches to the source code
of various categories.
>   A) Missing semicolons in the code
>   B) Changed implict casting from object to boolean to a explicit != null
>   C) Removed unused imports
>   D) Removed local variables that are unused and arguments of private functions that
are unused
>   E) Removed return statement in functions with : void signature
>   F) Changed variables named "dynamic" to a name that is not same as a keyword
>   G) Removed unused private methods

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message