incubator-flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tink <f...@tink.ws >
Subject Re: Overly large classes (was Flex incubation on Apache as Opensource)
Date Mon, 16 Jan 2012 08:20:57 GMT
On 15 Jan 2012, at 22:23, David Arno wrote:

> Tink, Jeffry,
>
> Maybe I've got confused, but I was describing spark.components.List,  
> which I
> assume is a spark component. This class might be less monolithic  
> than the
> halo version, but it is ridiculous to claim it implements composition.
>
> Take for example scrolling. In true composition, there would be a  
> reference
> to a scroll handler into which salient data would be injected and  
> that would
> be pretty much it. List though, has a scroller variable (of class type
> Scroller), which handles some aspects of scrolling, but there are  
> still lots
> and lots of lines of code, many deeply embedded inside long, complex,
> methods of List, that handle some aspects of scrolling. This isn't
> composition, it's just a messy bodge to enable support for spark  
> skinning.
>
> Fair point on editing though. That was a mistake on my part.
>
> David.
>
>



List exposes 2 styles, and 2 properties that is passes onto the  
Scroller instance.

There is also a small amount of code the make sure the selected index  
or carat is visible (as a Scroller doesn't have any logic for selected  
items).

Tink

Mime
View raw message