incubator-flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject mx:AdvancedDatagrid multi cell selection fix
Date Mon, 23 Jan 2012 02:41:59 GMT
Hi there,

Thought I'd submit a patch that has annoyed me for a long time with multi selection in the
mx AdvancedDataGrid not working correctly.

You can see this issue here:
http://bugs.adobe.com/jira/browse/FLEXDMV-2213

I'm not 100% familiar with the "Apache way" and how to submit patches to the SDK and I'm not
on the initial committer list so hopefully this is the right way to go about it.

I have compiled and tested this fix with the Flex SDK under the framework code and this patch
fixes the issue.

Here's the patch:
### Eclipse Workspace Patch 1.0
#P Apache Flex frameworks
Index: projects/advancedgrids/src/mx/controls/AdvancedDataGrid.as
===================================================================
--- projects/advancedgrids/src/mx/controls/AdvancedDataGrid.as	(revision 1234659)
+++ projects/advancedgrids/src/mx/controls/AdvancedDataGrid.as	(working copy)
@@ -1368,7 +1368,6 @@
         
         _temporary_selectedCells = value;
 		syncCellSelections(value);
-        clearPendingCells();
         selectedCellsChanged = true;
         invalidateProperties();
         invalidateDisplayList();
@@ -7610,6 +7609,8 @@
 
         caretBookmark  = null;
         anchorBookmark = null;
+		
+		clearPendingCells();
     }
 
     /**

I have a simple sample project to demo this bug but don't seem to be able to commit to the
 whiteboard. Do non committers have ability to commit to the whiteboard area and if so what's
the process to get access. (Sorry if I missed an email on this).

You'll note that the bug was closed and deferred in the Adobe JIRA bug base. Just wondering
what's going to happen with all of the closed and deferred bugs (there's a lot) once they
are moved over into the new JIRA bug base. I assume they will be reopened?

Thanks,
Justin


Justin Mclean
Consultant/Director
class SOFTWARE
Email:justin@classsoftware.com.au
Web:http://www.classsoftware.com
Blog:http://blog.classsoftware.com
Skype:justinmclean
Phone:+61 2 9368 1014
Mobile:+61 416 119 342




Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message