incubator-etch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Hindess <mark.hind...@googlemail.com>
Subject Re: [VOTE] 1.1 release packages
Date Tue, 12 Oct 2010 21:13:35 GMT

In message <00b301cb686a$dc443230$94cc9690$@com.au>, "Gav..." writes:
> 
> [SNIP]
>
> First off, some great Build and Readme files, very detailed.

Perhaps too detailed which makes it hard to keep up to date with respect
to dependencies.  For example, BUILD.txt says:

  Apache APR Util 1.3.12

but there is no such thing the latest is 1.3.10.  Later it also has:

  apr/
    1.3.2/
      [apr binary installation, see above]

but I assume this is out of date as the scripts/apr-install.sh script
creates:

  apr/
    apr/
    apr-util/
    apr-iconv/

I also notice that scripts/apr-install.* try to obtain
apr-util-1.3.9 from mirrors but the mirrors no longer hold
this release as apr-util-1.3.10 is now the latest so the
dependency should be updated or the url changed to use
http://archive.apache.org/dist/apr/apr-util-1.3.9...

The script should probably start with "set -e" to stop on errors (such
as those from wget) and should probably double quote "$INSTALL_PREFIX"
on (at least) the first if to avoid another likely error.  (I'm also
slightly puzzled as to why the install script downloads three things
and builds only two but I could be missing something subtle as I didn't
actually run it.)

> Some minor points (apologies for the length of some of these):

[SNIP]

> 4. You have LICENCE_THIRD_PARTY.txt and NOTICE_THIRD_PARTY.txt files
> -- both contain licenses and notices for the Apache APR project. APR
> is an Apache Licensed product, I don't think that counts as a third
> party license. I do not think that these files are needed. I will
> check this but I am not holding up the vote because of it.

You don't strictly need them in the source release since they are
downloaded and not distributed with the source.  However since you
are making binary releases with the same files, then the third party
attributions are required to be included in the NOTICE file of those
releases.  Therefore it probably makes sense to keep them.

I believe current guidelines suggest combining these (and don't need to
duplicate the ALv2) and just having a LICENSE and NOTICE files.  See:

  https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk/NOTICE
  https://svn.apache.org/repos/asf/harmony/enhanced/java/trunk/LICENSE

for an example (that happens to include APR).

I should note that you also use APR Util which has a different NOTICE
file.  That is:

  bash$ $ diff -udBbw apr-1.3.12/NOTICE apr-util-1.3.10/NOTICE 
--- apr-1.3.12/NOTICE   2009-07-02 03:45:11.000000000 +0100
+++ apr-util-1.3.10/NOTICE      2009-07-02 03:56:23.000000000 +0100
@@ -1,4 +1,4 @@
-Apache Portable Runtime
+Apache Portable Runtime Utility Library
 Copyright (c) 2009 The Apache Software Foundation.
 
 This product includes software developed by
@@ -9,7 +9,6 @@
 Illinois at Urbana-Champaign.
 
 This software contains code derived from the RSA Data Security
-Inc. MD5 Message-Digest Algorithm.
-
-This software contains code derived from UNIX V7, Copyright(C)
-Caldera International Inc.
+Inc. MD5 Message-Digest Algorithm, including various
+modifications by Spyglass Inc., Carnegie Mellon University, and
+Bell Communications Research, Inc (Bellcore).

I have no idea why but you should probably include all attributions
until it is clarified.

These are minor issues and, IMHO, not release blockers.

Regards,
 Mark.



Mime
View raw message