Return-Path: Delivered-To: apmail-incubator-etch-dev-archive@locus.apache.org Received: (qmail 7328 invoked from network); 20 Jan 2009 15:51:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 20 Jan 2009 15:51:23 -0000 Received: (qmail 13563 invoked by uid 500); 20 Jan 2009 15:51:23 -0000 Delivered-To: apmail-incubator-etch-dev-archive@incubator.apache.org Received: (qmail 13523 invoked by uid 500); 20 Jan 2009 15:51:23 -0000 Mailing-List: contact etch-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: etch-dev@incubator.apache.org Delivered-To: mailing list etch-dev@incubator.apache.org Received: (qmail 13500 invoked by uid 99); 20 Jan 2009 15:51:23 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Jan 2009 07:51:22 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Jan 2009 15:51:21 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id B38A0234C4A8 for ; Tue, 20 Jan 2009 07:50:59 -0800 (PST) Message-ID: <1822163396.1232466659734.JavaMail.jira@brutus> Date: Tue, 20 Jan 2009 07:50:59 -0800 (PST) From: "scott comer (JIRA)" To: etch-dev@incubator.apache.org Subject: [jira] Assigned: (ETCH-25) DefaultDeliveryService ends call with mb.CloseDelivery() and it should end it with mb.CloseRead() In-Reply-To: <36568695.1231946882616.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/ETCH-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] scott comer reassigned ETCH-25: ------------------------------- Assignee: scott comer > DefaultDeliveryService ends call with mb.CloseDelivery() and it should end it with mb.CloseRead() > ------------------------------------------------------------------------------------------------- > > Key: ETCH-25 > URL: https://issues.apache.org/jira/browse/ETCH-25 > Project: Etch > Issue Type: Bug > Components: csharp-binding, java-binding > Affects Versions: 1.0.0, 1.0.1 > Reporter: scott comer > Assignee: scott comer > > when done reading the mailbox, the right method to call is CloseRead(). somehow the code actually calls CloseDelivery(), a method used to shutdown the writing side of the mailbox. CloseRead() calls CloseDelivery() first off, but then takes the additional steps of redelivering any messages left in the mailbox. > The distinction is rather fine, and this bug was found by reading the source code. There are certain ways you could exercise this bug, but it would be very rare and not have any real impact. So, it isn't an emergency to fix it, but it is also a relatively benign fix. I've already made the change in my tree and tested it. The patch is attached. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.