incubator-esme-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vladimir Ivanov <lester.m...@gmail.com>
Subject Re: Move to latest Lift release for 1.2
Date Thu, 16 Dec 2010 03:07:50 GMT
As a temporary solution, I suggest to replace ValById and SetValById case
classes with JsRaw in this specific case. Following
modified UserSnip.postScript() method returns the same JS code as in
Lift2.2-RC1 version:

def postScript(in: NodeSeq): NodeSeq =
  <xml:group>
    {Script(JsonPoster.jsCmd)}
    {Script(Function("post_msg", List(),
                     JsonPoster.call("post",
                                      JsObj("msg" ->
JsRaw("""document.getElementById("vMsg").value"""),
                                            "tags" ->
JsRaw("""document.getElementById("vTag").value"""),
                                            "access_pool" ->
JsRaw("""document.getElementById("vPool").value"""),
                                            "reply-to" ->
JsVar("currentConvNumber"))) &
                     JsRaw("""document.getElementById("vMsg").value = """"")
&
                     JsRaw("""document.getElementById("vMsg").value =
"0"""") &
                     JsRaw("clearReplyTo();")
        ))
    }
  </xml:group>


Need some time/advice to refine this code.

2010/12/16 Vladimir Ivanov <lester.mail@gmail.com>

> I've found that slightly different JavaScript is generated by
> classes ValById and SetValById.
>
> Lift2.2-RC1:
>
> function post_msg() {
>     F967851111816BL5({'command': "post", 'params':{"msg": if
> (document.getElementById("vMsg")) {document.getElementById("vMsg").value;}
> else {null;}, "tags": if (document.getElementById("vTag"))
> {document.getElementById("vTag").value;} else {null;}, "access_pool": if
> (document.getElementById("vPool")) {document.getElementById("vPool").value;}
> else {null;}, "reply-to": currentConvNumber}});
> if (document.getElementById("vMsg")) {document.getElementById("vMsg").value
> = "";};
> if (document.getElementById("vPool"))
> {document.getElementById("vPool").value = "0";};
> clearReplyTo();;
>     }
>
> Lift2.2-RC1:
>
> function post_msg() {
>     F240718098783O1W({'command': "post", 'params':{"msg":
> document.getElementById("vMsg").value, "tags":
> document.getElementById("vTag").value, "access_pool":
> document.getElementById("vPool").value, "reply-to": currentConvNumber}});
> document.getElementById("vMsg").value = "";
> document.getElementById("vPool").value = "0";
> clearReplyTo();;
>     }
>
>
> As far as I understand this was done as part of fix for Lift #766 issue:
> https://www.assembla.com/spaces/liftweb/tickets/766-make-setvalbyid-more-forgiving
>
> It's good thing to check JS element for existence before getting/setting
> it's value, but in our case if statements become problem when nested inside
> JSON.
>
> 2010/12/15 Vladimir Ivanov <lester.mail@gmail.com>
>
> Guys,
>>
>> Lift 2.2-RC2 has been announced today:
>> http://lift.la/announcing-lift-22-rc2
>>
>> <http://lift.la/announcing-lift-22-rc2>I tried to update project to this
>> version locally. Source code was compiled and all tests were passed, but I
>> experienced problem at runtime: I'm unable to post new message to timeline,
>> after pressing 'Update' button nothing happens. IE7 returns JavaScript error
>> in post_msg function:
>>
>> <script type="text/javascript">
>> // <![CDATA[
>> function post_msg() {
>>     F2397955938923CK({'command': "post", 'params':{"msg": if
>> (document.getElementById("vMsg")) {document.getElementById("vMsg").value;}
>> else {null;}, "tags": if (document.getElementById("vTag"))
>> {document.getElementById("vTag").value;} else {null;}, "access_pool": if
>> (document.getElementById("vPool")) {document.getElementById("vPool").value;}
>> else {null;}, "reply-to": currentConvNumber}});
>> if (document.getElementById("vMsg"))
>> {document.getElementById("vMsg").value = "";};
>> if (document.getElementById("vPool"))
>> {document.getElementById("vPool").value = "0";};
>> clearReplyTo();;
>>     }
>> // ]]>
>> </script>
>>
>> This function is implemented in UserSnip.postScript() method. May be
>> somthing was changed in JSON processing... Do you guys discover the same?
>>
>> Btw, I tried to make minor fix for ESME-274 UI issue, it works for me,
>> could someone of developers check it on Lift2.2-RC1?
>>
>> 2010/12/14 Richard Hirsch <hirsch.dick@gmail.com>
>>
>>> Just deployed a clean version on Stax and it works. Yeah.
>>>
>>> Serves me right for playing around with my deployments.
>>>
>>> Please test.
>>>
>>> If tests go well today and tomorrow, we could merge the branch into the
>>> trunk.
>>>
>>> D.
>>>
>>> On Tue, Dec 14, 2010 at 5:19 PM, Vladimir Ivanov <lester.mail@gmail.com>
>>> wrote:
>>> > Ethan,
>>> >
>>> > I'm using Chrome 8.0.552.224 beta on Windows right now. I'll try
>>> Firefox 3.5
>>> > and IE 7 when you deploy new version.
>>> >
>>> > 2010/12/14 Richard Hirsch <hirsch.dick@gmail.com>
>>> >
>>> >> Wait a second. I could be the cause of the error - I forgot to change
>>> >> a test Javascript that I changed.
>>> >>
>>> >> Deploying again....
>>> >>
>>> >> D.
>>> >>
>>> >> On Tue, Dec 14, 2010 at 5:10 PM, Ethan Jewett <esjewett@gmail.com>
>>> wrote:
>>> >> > Ok, this prompted me to check in IE and I am indeed getting a
>>> >> > javascript error there. I'm not going to be able to recreate that
>>> >> > locally because I am not set up to build ESME on Windows.
>>> >> >
>>> >> > What version of Chrome are you using?
>>> >> >
>>> >> > Vladimir, what browser are you using?
>>> >> >
>>> >> > Dick, you can switch it back whenever you want. Seems that it is
a
>>> JS
>>> >> > error in the message display code and we'll have to work through
>>> that.
>>> >> >
>>> >> > Ethan
>>> >> >
>>> >> > On Tue, Dec 14, 2010 at 5:00 PM, Richard Hirsch <
>>> hirsch.dick@gmail.com>
>>> >> wrote:
>>> >> >> On Tue, Dec 14, 2010 at 4:49 PM, Ethan Jewett <esjewett@gmail.com>
>>> >> wrote:
>>> >> >>> It is working fine for me - Chrome on Windows at the moment.
>>> >> >>> http://esmecloudserverapache.dickhirsch.staxapps.net/ -
right?
>>> >> >>>
>>> >> >>> Can you see my new messages?
>>> >> >>
>>> >> >> Nope.
>>> >> >>
>>> >> >>>
>>> >> >>> Ethan
>>> >> >>>
>>> >> >>> On Tue, Dec 14, 2010 at 4:17 PM, Richard Hirsch <
>>> hirsch.dick@gmail.com>
>>> >> wrote:
>>> >> >>>> I just looked.
>>> >> >>>>
>>> >> >>>> The data is there but still it doesn't work in IE or
Chrome.
>>> >> >>>>
>>> >> >>>> Please tell me when I can redeploy the older version.
>>> >> >>>>
>>> >> >>>> D.
>>> >> >>>>
>>> >> >>>> On Tue, Dec 14, 2010 at 4:07 PM, Richard Hirsch <
>>> >> hirsch.dick@gmail.com> wrote:
>>> >> >>>>> Redeployed the 2.2 version on stax. It still doesn't
work me.
>>> >> >>>>>
>>> >> >>>>> Please test.
>>> >> >>>>>
>>> >> >>>>> D.
>>> >> >>>>>
>>> >> >>>>> On Tue, Dec 14, 2010 at 4:03 PM, Ethan Jewett <
>>> esjewett@gmail.com>
>>> >> wrote:
>>> >> >>>>>> Hi Vladimir,
>>> >> >>>>>>
>>> >> >>>>>> On Stax we are using an external MySQL database,
so the old
>>> messages
>>> >> >>>>>> should persist.
>>> >> >>>>>>
>>> >> >>>>>> Dick, how hard would it be to redeploy the
Lift 2.2 version to
>>> Stax?
>>> >> >>>>>> I'd like to take a look and see if the problem
is on the
>>> front-end
>>> >> (a
>>> >> >>>>>> javascript issue).
>>> >> >>>>>>
>>> >> >>>>>> Ethan
>>> >> >>>>>>
>>> >> >>>>>> On Tue, Dec 14, 2010 at 3:55 PM, Vladimir Ivanov
<
>>> >> lester.mail@gmail.com> wrote:
>>> >> >>>>>>> As far as I understand, for embedded Derby
instance in another
>>> >> branch
>>> >> >>>>>>> (folder) it will be completely new instance,
without data.
>>> >> >>>>>>>
>>> >> >>>>>>> 2010/12/14 Richard Hirsch <hirsch.dick@gmail.com>
>>> >> >>>>>>>
>>> >> >>>>>>>> I looked at the log on stax and I didn't
see any errors. I
>>> didn't
>>> >> >>>>>>>> create any new messages I just looked
to see if existing ones
>>> >> showed
>>> >> >>>>>>>> up.
>>> >> >>>>>>>>
>>> >> >>>>>>>> I haven't tried the new version locally
- maybe, you could
>>> give it
>>> >> a try.
>>> >> >>>>>>>>
>>> >> >>>>>>>> D.
>>> >> >>>>>>>>
>>> >> >>>>>>>> On Tue, Dec 14, 2010 at 3:23 PM, Vladimir
Ivanov <
>>> >> lester.mail@gmail.com>
>>> >> >>>>>>>> wrote:
>>> >> >>>>>>>> > Richard,
>>> >> >>>>>>>> >
>>> >> >>>>>>>> > Have you seen any exceptions,
errors etc? New messages
>>> aren't
>>> >> posted and
>>> >> >>>>>>>> > displayed in timeline, are them?
>>> >> >>>>>>>> >
>>> >> >>>>>>>> > 2010/12/14 Richard Hirsch <hirsch.dick@gmail.com>
>>> >> >>>>>>>> >
>>> >> >>>>>>>> >> just deployed on stax and
saw that the timelines didn't
>>> work,
>>> >> so I
>>> >> >>>>>>>> >> redeployed an older version.
>>> >> >>>>>>>> >>
>>> >> >>>>>>>> >> So it looks like we have some
more work to do with the 2.2
>>> >> port.
>>> >> >>>>>>>> >>
>>> >> >>>>>>>> >> D.
>>> >> >>>>>>>> >>
>>> >> >>>>>>>> >> On Tue, Dec 14, 2010 at 10:28
AM, Ethan Jewett <
>>> >> esjewett@gmail.com>
>>> >> >>>>>>>> wrote:
>>> >> >>>>>>>> >> > "list :-) newItem" means
"replace the last item in the
>>> list
>>> >> with
>>> >> >>>>>>>> >> > newItem". Obviously ;-)
>>> >> >>>>>>>> >> >
>>> >> >>>>>>>> >> > On Tue, Dec 14, 2010
at 10:16 AM,
>>> >> darren.hague@fortybeans.com
>>> >> >>>>>>>> >> > <dhague@fortybeans.com>
wrote:
>>> >> >>>>>>>> >> >> Was that a smiley
at the end, or another new
>>> operator...?
>>> >> >>>>>>>> >> >>
>>> >> >>>>>>>> >> >>
>>> >> >>>>>>>> >> >>
>>> >> >>>>>>>> >> >> On 14 December 2010
at 07:07 Ethan Jewett <
>>> >> esjewett@gmail.com>
>>> >> >>>>>>>> wrote:
>>> >> >>>>>>>> >> >>
>>> >> >>>>>>>> >> >>> Thanks both of
you. This is great! :-)
>>> >> >>>>>>>> >> >>>
>>> >> >>>>>>>> >> >>> I love learning
something new this early in the
>>> morning,
>>> >> even if it
>>> >> >>>>>>>> is
>>> >> >>>>>>>> >> >>> a little bit
early for that many : + and = operators
>>> :-)
>>> >> >>>>>>>> >> >>>
>>> >> >>>>>>>> >> >>> Ethan
>>> >> >>>>>>>> >> >>>
>>> >> >>>>>>>> >> >>> On Tue, Dec 14,
2010 at 6:00 AM, Vassil Dichev <
>>> >> vdichev@apache.org>
>>> >> >>>>>>>> >> wrote:
>>> >> >>>>>>>> >> >>> >> Thanks
to Richard, Ethan and Vassil, it seems ESME
>>> has
>>> >> been
>>> >> >>>>>>>> >> successfully
>>> >> >>>>>>>> >> >>> >> migrated
to Scala 2.8 and Lift 2.2!
>>> >> >>>>>>>> >> >>> >
>>> >> >>>>>>>> >> >>> > ... and
thanks to your quick help! Also: "Yay for
>>> tests"!
>>> >> >>>>>>>> >> >>> >
>>> >> >>>>>>>> >> >
>>> >> >>>>>>>> >>
>>> >> >>>>>>>> >
>>> >> >>>>>>>> >
>>> >> >>>>>>>> >
>>> >> >>>>>>>> > --
>>> >> >>>>>>>> > Best Regards,
>>> >> >>>>>>>> > Vladimir Ivanov
>>> >> >>>>>>>> >
>>> >> >>>>>>>>
>>> >> >>>>>>>
>>> >> >>>>>>>
>>> >> >>>>>>>
>>> >> >>>>>>> --
>>> >> >>>>>>> Best Regards,
>>> >> >>>>>>> Vladimir Ivanov
>>> >> >>>>>>>
>>> >> >>>>>>
>>> >> >>>>>
>>> >> >>>>
>>> >> >>>
>>> >> >>
>>> >> >
>>> >>
>>> >
>>> >
>>> >
>>> > --
>>> > Best Regards,
>>> > Vladimir Ivanov
>>> >
>>>
>>
>>
>>
>> --
>> Best Regards,
>> Vladimir Ivanov
>>
>
>
>
> --
> Best Regards,
> Vladimir Ivanov
>



-- 
Best Regards,
Vladimir Ivanov

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message