Return-Path: Delivered-To: apmail-incubator-esme-dev-archive@minotaur.apache.org Received: (qmail 395 invoked from network); 19 Oct 2010 11:26:23 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 19 Oct 2010 11:26:23 -0000 Received: (qmail 84272 invoked by uid 500); 19 Oct 2010 11:26:23 -0000 Delivered-To: apmail-incubator-esme-dev-archive@incubator.apache.org Received: (qmail 84213 invoked by uid 500); 19 Oct 2010 11:26:21 -0000 Mailing-List: contact esme-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: esme-dev@incubator.apache.org Delivered-To: mailing list esme-dev@incubator.apache.org Received: (qmail 84205 invoked by uid 99); 19 Oct 2010 11:26:20 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Oct 2010 11:26:20 +0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of vdichev@gmail.com designates 209.85.214.47 as permitted sender) Received: from [209.85.214.47] (HELO mail-bw0-f47.google.com) (209.85.214.47) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Oct 2010 11:26:14 +0000 Received: by bwz9 with SMTP id 9so1420051bwz.6 for ; Tue, 19 Oct 2010 04:25:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:content-type:content-transfer-encoding; bh=biy2F2ZiJQIRPnwnhdt3714kpyeir6M2kq7n+emu4Yw=; b=rPyi38ehZj2an93CIIYfySBYTUYIEDxIJ38uh+e86mNyVBpTbwO/WMJoebWh1GiKA8 +RDC4sgKkyffeAwgyT9mbwc3R+c1V1tWTLEu1Kxno2z4yk4iXrKdzre/DbrqMCuVzF3H oKLC3GLJllBIU59nF+p0k/SPRs5vhMk9rWY5M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; b=BlEcNm8tjQLzAXQceFlkbS9KrtB6eQeJ7nEHMobnS2Iu5jyD6f55cpBPkSzzWGiXR4 9oOqiLbb2NyC8fzNddJyJ8I7S5HHgGAflrjActjPHWu+3+1FuFBr9sHnivigFOaQEVAh qEbMmUvkPNfeAMZDnx9drto0PjmzxmNNAxOec= MIME-Version: 1.0 Received: by 10.204.53.4 with SMTP id k4mr5476788bkg.145.1287487553251; Tue, 19 Oct 2010 04:25:53 -0700 (PDT) Sender: vdichev@gmail.com Received: by 10.204.99.199 with HTTP; Tue, 19 Oct 2010 04:25:53 -0700 (PDT) In-Reply-To: References: Date: Tue, 19 Oct 2010 14:25:53 +0300 X-Google-Sender-Auth: _LOw4lsR8mYuMj394aKHV9bpU6I Message-ID: Subject: Re: ESME-291 - replies duplicated in streams and public timeline From: Vassil Dichev To: esme-dev@incubator.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org Now my conversation messages are not duplicated *and* the conversation is recorded. Can you check if it works? On Tue, Oct 19, 2010 at 12:08 PM, Richard Hirsch wr= ote: > In the timeline, the link for the conversation is missing - therefore > it is tough to see if the reply is really part of the conversation or > not. > > On Tue, Oct 19, 2010 at 11:04 AM, Vassil Dichev wrot= e: >> Ah, you mean the link with the conversation? Got it. Let me try to fix t= his. >> >> On Tue, Oct 19, 2010 at 11:30 AM, Richard Hirsch = wrote: >>> I just deployed vassil's change on stax ( >>> http://esmecloudserverapache.dickhirsch.staxapps.net/) =A0and the >>> conversations don't work any more - they don't show up in the timeline >>> :-< >>> >>> >>> On Tue, Oct 19, 2010 at 9:43 AM, Ethan Jewett wrot= e: >>>> Far more sophisticated than the println "instrumentation" I was using.= I'll >>>> keep that in mind for the future. I hadn't paid much attention to the >>>> after-hook methods in the MetaMapper until now. >>>> >>>> Ethan >>>> >>>> On Tue, Oct 19, 2010 at 9:20 AM, Vassil Dichev wr= ote: >>>> >>>>> Heh, I added an afterSave handler with Thread.dumpStack to show me >>>>> where does the double save occur. >>>>> >>>>> On Tue, Oct 19, 2010 at 9:49 AM, Ethan Jewett wr= ote: >>>>> > Hi Vassil, >>>>> > >>>>> > I got as far as confirming the the message ids are different, so it >>>>> > looks to me like two messages are created and saved. I then started >>>>> > looking for where the second message is created and didn't make any >>>>> > progress. My tests seemed to show the the method creation code in >>>>> > UserActor was only called once. >>>>> > >>>>> > If you can find some time to investigate, that would be excellent. >>>>> > >>>>> > Ethan >>>>> > >>>>> > On Tuesday, October 19, 2010, Vassil Dichev wr= ote: >>>>> >> An action is not likely to create a duplicate message, as even whe= n it >>>>> >> resends, a new message is never created and the mailbox is checked= if >>>>> >> such a message exists. I've solved at least 2 duplication bugs so = far >>>>> >> and the problem has always been that the same message was visualiz= ed >>>>> >> twice. >>>>> >> >>>>> >> The first thing to look for is the id of the message in the page >>>>> >> source- if the id is the same, then it's the same message shown tw= ice >>>>> >> by the UI. >>>>> >> >>>>> >> I'd like to take a look at the problem and check if I see an easy >>>>> solution. >>>>> >> >>>>> >> Vassil >>>>> >> >>>>> >> >>>>> >> On Tue, Oct 19, 2010 at 5:32 AM, Richard Hirsch >>>>> wrote: >>>>> >>> On Mon, Oct 18, 2010 at 7:30 PM, Ethan Jewett >>>>> wrote: >>>>> >>>> No, I don't think so. I did a clean install locally last week an= d I >>>>> only >>>>> >>>> have the RSS-pull action set up. It's a ghost in the machine som= ewhere >>>>> ;-) I >>>>> >>>> spent some time tracing through actor messaging paths and I gues= s I'll >>>>> just >>>>> >>>> need to spend a little more time on it. >>>>> >>>> >>>>> >>>> An alternative would be to find an SVN check-in that doesn't hav= e the >>>>> issue >>>>> >>>> and then track down the exact change that caused the problem. No= t sure >>>>> which >>>>> >>>> will be more difficult ... >>>>> >>> >>>>> >>> This would probably be a challenge - especially if the problem ha= s >>>>> >>> been around for a while. >>>>> >>> >>>>> >>> D. >>>>> >>>> >>>>> >>>> Ethan >>>>> >>>> >>>>> >>>> On Mon, Oct 18, 2010 at 5:51 PM, Richard Hirsch < >>>>> hirsch.dick@gmail.com>wrote: >>>>> >>>> >>>>> >>>>> On Mon, Oct 18, 2010 at 5:41 PM, Ethan Jewett >>>>> wrote: >>>>> >>>>> > Hi all, >>>>> >>>>> > >>>>> >>>>> > Dick did some testing after my commits today and found a coup= le of >>>>> >>>>> issues. >>>>> >>>>> > The first (ESME-290) was that I broke the public timeline. Th= at is >>>>> now >>>>> >>>>> > fixed. >>>>> >>>>> > >>>>> >>>>> > The second issue is ESME-291 - >>>>> >>>>> > https://issues.apache.org/jira/browse/ESME-291. =A0The proble= m is >>>>> that >>>>> >>>>> replies >>>>> >>>>> > show up duplicated in the streams view and in the public time= line >>>>> view >>>>> >>>>> > (though in the public timeline view it is *only* for messages= that >>>>> were >>>>> >>>>> > created before the public timeline actor started up, so if yo= u >>>>> create new >>>>> >>>>> > replies you need to restart the server to see them duplicated= in >>>>> the >>>>> >>>>> public >>>>> >>>>> > timeline). This is actually an old issue. It exists at least = in >>>>> release >>>>> >>>>> 1.1 >>>>> >>>>> > and probably well before that. >>>>> >>>>> > >>>>> >>>>> > The reason this is happening is that when a reply is created = there >>>>> are >>>>> >>>>> > actually two messages created and persisted to the database. = One is >>>>> >>>>> created >>>>> >>>>> > in the UserActor, which is what is supposed to happen. But an= other >>>>> >>>>> message >>>>> >>>>> > is created somewhere else and I can't figure out where! Any i= deas? >>>>> >>>>> >>>>> >>>>> Some action maybe? >>>>> >>>>> >>>>> >>>>> Maybe Vassil has an idea. >>>>> >>>>> > >>>>> >>>>> > Ethan >>>>> >>>>> > >>>>> >>>>> >>>>> >>>> >>>>> >>> >>>>> >> >>>>> >> >>>>> >> >>>>> >> -- >>>>> >> Twitter: http://twitter.com/vdichev >>>>> >> Blog: http://speaking-my-language.blogspot.com >>>>> >> >>>>> > >>>>> >>>>> >>>>> >>>>> -- >>>>> Twitter: http://twitter.com/vdichev >>>>> Blog: http://speaking-my-language.blogspot.com >>>>> >>>> >>> >> >> >> >> -- >> Twitter: http://twitter.com/vdichev >> Blog: http://speaking-my-language.blogspot.com >> > --=20 Twitter: http://twitter.com/vdichev Blog: http://speaking-my-language.blogspot.com