incubator-esme-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ethan Jewett <esjew...@gmail.com>
Subject Re: svn commit: r979760 - /incubator/esme/branches/metadata/src/test/scala/org/apache/esme/api/API2Test.scala
Date Tue, 27 Jul 2010 16:59:30 GMT
Ok, sounds good to me.

With regards to the issue: I think we are doing something in the tests
that is causing ESME to break internally, but it is not breakage that
affects functionality, so I assume that an actor is dying off
somewhere and then getting recreated when it is needed. This is not
ideal if it's what's happening, but it's not the end of the world
either. It's certainly something that we should look into.

Ethan

On Tue, Jul 27, 2010 at 6:56 PM, Imtiaz Ahmed H E <in.imtiaz@gmail.com> wrote:
> Ethan,
> I would suggest, just commit. I know nothing about the tests...I just
> noticed the 'break' in the tests' output....that's all....you say all the
> tests still pass....so, commit.
>
> Imtiaz
>
> ----- Original Message ----- From: "Ethan Jewett" <esjewett@gmail.com>
> To: <esme-dev@incubator.apache.org>
> Sent: Tuesday, July 27, 2010 10:19 PM
> Subject: Re: svn commit: r979760 -
> /incubator/esme/branches/metadata/src/test/scala/org/apache/esme/api/API2Test.scala
>
>
> Hi Imtiaz,
>
> I think it's an unrelated issue, since all the tests still pass. I
> believe Dick was looking into it before his vacation, but I'm not
> sure.
>
> Let me know if you think we're ready to check this into trunk. I've
> already merged locally and I was going to commit, but if you're not
> comfortable with these results we can keep working on it.
>
> Thanks,
> Ethan
>
> On Tue, Jul 27, 2010 at 6:23 PM, Imtiaz Ahmed H E <in.imtiaz@gmail.com>
> wrote:
>>
>> Ethan,
>>
>> I svn updated my read-only checkout of ESME and did an mvn install, the
>> tests started running and I got in between the following for api2(?), Is
>> it
>> okay ?
>>
>> INFO - Service request (POST) /api2/user/messages took 297 Milliseconds
>> INFO - Service request (GET) /api2/user/messages took 0 Milliseconds
>> INFO - Service request (POST) /api2/session took 16 Milliseconds
>> INFO - Service request (POST) /api2/user/messages took 0 Milliseconds
>> INFO - Service request (POST) /api2/session took 15 Milliseconds
>> INFO - Service request (POST) /api2/user/messages took 188 Milliseconds
>> INFO - Service request (POST) /api2/session took 16 Milliseconds
>> [Fatal Error] :1:1: Content is not allowed in prolog.
>> INFO - Service request (POST) /api2/user/messages took 187 Milliseconds
>> INFO - Service request (GET) /api2/user/followees took 78 Milliseconds
>> INFO - Service request (POST) /api2/session took 0 Milliseconds
>> INFO - Service request (GET) /api2/user/followees took 0 Milliseconds
>>
>> and....
>>
>> INFO - Service request (DELETE) /api2/user/actions/2 took 204 Milliseconds
>> INFO - Service request (POST) /api2/session took 0 Milliseconds
>> INFO - Service request (DELETE) /api2/user/actions/1 took 0 Milliseconds
>> INFO - Service request (POST) /api2/user/messages took 141 Milliseconds
>> :6:7: expected closing tag of hr
>> ^
>> :6:7: expected closing tag of hr
>> ^
>> INFO - Service request (POST) /api2/user/messages took 344 Milliseconds
>> INFO - Service request (GET) /api2/conversations/9 took 31 Milliseconds
>> INFO - Service request (POST) /api2/session took 0 Milliseconds
>>
>> Imtiaz
>>
>> ----- Original Message ----- From: <esjewett@apache.org>
>> To: <esme-commits@incubator.apache.org>
>> Sent: Tuesday, July 27, 2010 9:34 PM
>> Subject: svn commit: r979760 -
>>
>> /incubator/esme/branches/metadata/src/test/scala/org/apache/esme/api/API2Test.scala
>>
>>
>>> Author: esjewett
>>> Date: Tue Jul 27 16:04:01 2010
>>> New Revision: 979760
>>>
>>> URL: http://svn.apache.org/viewvc?rev=979760&view=rev
>>> Log:
>>> [ESME-242] Updated tests for metadata issue - now passing
>>>
>>> Modified:
>>>
>>>
>>>
>>> incubator/esme/branches/metadata/src/test/scala/org/apache/esme/api/API2Test.scala
>>>
>>> Modified:
>>>
>>> incubator/esme/branches/metadata/src/test/scala/org/apache/esme/api/API2Test.scala
>>> URL:
>>>
>>> http://svn.apache.org/viewvc/incubator/esme/branches/metadata/src/test/scala/org/apache/esme/api/API2Test.scala?rev=979760&r1=979759&r2=979760&view=diff
>>>
>>>
>>> ==============================================================================
>>> ---
>>>
>>> incubator/esme/branches/metadata/src/test/scala/org/apache/esme/api/API2Test.scala
>>> (original)
>>> +++
>>>
>>> incubator/esme/branches/metadata/src/test/scala/org/apache/esme/api/API2Test.scala
>>> Tue Jul 27 16:04:01 2010
>>> @@ -377,11 +377,11 @@ object Api2Specs extends Specification w
>>> session <- post_session
>>> mess_res <- session.post("user/messages",
>>> "message" -> "test POST message",
>>> - "metadata" ->
>>>
>>> "<outer><meta><metameta>Hello</metameta></meta><onlymeta>Meta</onlymeta></outer>")
>>> + "metadata" ->
>>>
>>> """<outer><meta><metameta>"Hello"</metameta></meta><onlymeta>Meta</onlymeta></outer>""")
>>> } {
>>> - mess_res.code must be equalTo 200
>>> + mess_res.code must be equalTo 200
>>> (mess_res.xml.open_! \ "message") must \\ (<body>test POST
>>> message</body>)
>>> - (mess_res.xml.open_! \\ "metadata") must be equalTo
>>>
>>> <metadata><outer><meta><metameta>Hello</metameta></meta><onlymeta>Meta</onlymeta></outer></metadata>
>>> + (mess_res.xml.open_! \\ "metadata").toString must be equalTo
>>>
>>> """<metadata><outer><meta><metameta>&quot;Hello&quot;</metameta></meta><onlymeta>Meta</onlymeta></outer></metadata>"""
>>> }
>>> }
>>>
>>> @@ -392,9 +392,9 @@ object Api2Specs extends Specification w
>>> "message" -> "test POST message",
>>> "metadata" ->
>>>
>>> """"meta":[{"place":{"place_type":"city","region":"CA+"}},{"song":{"artist":"Prince","songtitle":"Never+Let+Me+Down"}}]""")
>>> } {
>>> - mess_res.code must be equalTo 200
>>> + mess_res.code must be equalTo 200
>>> (mess_res.xml.open_! \ "message") must \\ (<body>test POST
>>> message</body>)
>>> - (mess_res.xml.open_! \\ "metadata") must be equalTo
>>>
>>> <metadata>{""""meta":[{"place":{"place_type":"city","region":"CA+"}},{"song":{"artist":"Prince","songtitle":"Never+Let+Me+Down"}}]"""}</metadata>
>>> + (mess_res.xml.open_! \\ "metadata").text must be equalTo
>>>
>>> """"meta":[{"place":{"place_type":"city","region":"CA+"}},{"song":{"artist":"Prince","songtitle":"Never+Let+Me+Down"}}]"""
>>> }
>>> }
>>> }
>>>
>>>
>>
>>
>
>

Mime
View raw message