Return-Path: Delivered-To: apmail-incubator-esme-dev-archive@minotaur.apache.org Received: (qmail 20406 invoked from network); 6 Apr 2010 20:29:32 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 6 Apr 2010 20:29:32 -0000 Received: (qmail 49483 invoked by uid 500); 6 Apr 2010 20:29:32 -0000 Delivered-To: apmail-incubator-esme-dev-archive@incubator.apache.org Received: (qmail 49455 invoked by uid 500); 6 Apr 2010 20:29:32 -0000 Mailing-List: contact esme-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: esme-dev@incubator.apache.org Delivered-To: mailing list esme-dev@incubator.apache.org Received: (qmail 49447 invoked by uid 99); 6 Apr 2010 20:29:32 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Apr 2010 20:29:32 +0000 X-ASF-Spam-Status: No, hits=-1.1 required=10.0 tests=AWL,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of esjewett@gmail.com designates 209.85.222.181 as permitted sender) Received: from [209.85.222.181] (HELO mail-pz0-f181.google.com) (209.85.222.181) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Apr 2010 20:29:25 +0000 Received: by pzk11 with SMTP id 11so309915pzk.32 for ; Tue, 06 Apr 2010 13:29:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:received:message-id:subject:from:to:content-type :content-transfer-encoding; bh=sXNksb1unm/27uDucnjITjlMxJrlIdj/tdj3576lNf4=; b=mMr+bSjVEsDgBzURDlH/Kr7PgPehm+l0LtY5mig7zIQNbP9QlIVgvwHztzqdu5IXDW 6enY0w5i81dvNMlyXOJLtUg+R2lEd+ViXcwTO5gMnIZQCD71Za9+bBxRNXm5RXoEhM80 V8YDWZI+HgqQUEUYvozrVtqDdKUoD0oa59e4U= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=Rgcl7U25SpTO/QldiMusbSokt5a/cmAVs570IRKQbBkx05PGJAQAR6rcyOYv/6lJZl WQhw3Zaysk1XLGWBhI6j7Pu2lenHs557L/HAfIoF4ea9jct96l9XZuycr2feYY1JDI+M KA+Kqz9kRuv/DtSZUPd4I1CxLDJ5nHsI8dYps= MIME-Version: 1.0 Received: by 10.140.169.15 with HTTP; Tue, 6 Apr 2010 13:29:03 -0700 (PDT) In-Reply-To: References: <20100401233310.BFAB32388978@eris.apache.org> <721088BB-04B4-4959-85A9-7D9E3BBE682E@gmail.com> <96B286FE-CC6E-4970-B7EC-DC1079A0E2A0@gmail.com> Date: Tue, 6 Apr 2010 16:29:03 -0400 Received: by 10.141.88.1 with SMTP id q1mr4676359rvl.198.1270585743627; Tue, 06 Apr 2010 13:29:03 -0700 (PDT) Message-ID: Subject: Re: svn commit: r930136 - in /incubator/esme/trunk/server/src/main/webapp: style/style.css templates-hidden/message.html From: Ethan Jewett To: esme-dev@incubator.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Thanks for doing this! I guess I'd leave it open until we have a more permanent fix, but maybe lower the "badness" of the issue and make a note of why that is happening? I'm actually starting to think that the best way to do this is to have the javascript that populates the message text that is being replied to truncate that text to 140 characters (or something). The user just needs a sample and JS has easy functions for doing this. Hmmm. Maybe tonight. What do you think? Do we want truncation or stretching as our final fix for this issue? Ethan On Tue, Apr 6, 2010 at 3:58 PM, Anne Kathrine Petter=F8e wrote: > If we encourage our users not to use more than 140 characters (which I al= ways thought we should) - we are now safe. Shall I leave the ticket open as= this is a bit of a quick fix, seeing we haven't imposed any limits for how= long the messages can be. (yet) > > /Anne > > > On 4. apr. 2010, at 01.44, Ethan Jewett wrote: > >> Hi, >> >> I already opened ESME-188 for this issue (the input area expanding) - >> https://issues.apache.org/jira/browse/ESME-188 >> >> I don't think we need to move anything. Instead, we either need to >> restrict the total length of the "reply to" section to only display >> part of the message being replied to, or we need to make the input >> area background expand dynamically to accomodate varied message >> lengths. >> >> Ethan >> >> On Sat, Apr 3, 2010 at 11:01 AM, Anne Kathrine Petter=F8e >> wrote: >>> I'll take a look at it tomorrow. >>> We could also make the update box background a bit longer too. >>> >>> On 3. apr. 2010, at 18.57, Richard Hirsch wrote: >>> >>>> Maybe it was some other tool. =A0Smaller font and other color (grey?) = might be >>>> one option >>>> >>>> On Sat, Apr 3, 2010 at 6:55 PM, Anne Kathrine Petter=F8e wrote: >>>> >>>>> I will take a look at it during tomorrow's daily UI hour, but smaller= font >>>>> might be one solution. >>>>> twitter doesn't display the "reply to:" at all and brizzly displays a= n >>>>> reply to box inline. >>>>> >>>>> >>>>> On 3. apr. 2010, at 18.52, Richard Hirsch wrote: >>>>> >>>>>> let's look at how twitter / brizzly do it. They use a smaller font. >>>>>> >>>>>> On Sat, Apr 3, 2010 at 6:07 PM, Anne Kathrine Petter=F8e < >>>>> yojibee@gmail.com>wrote: >>>>>> >>>>>>> I like it :-) >>>>>>> >>>>>>> Now sort of unrelated. >>>>>>> I think we need to move the "reply to" function, as it currently is= it >>>>>>> pushes the Share with and Update button out of the "what are you wo= rking >>>>> on" >>>>>>> box. Where should we move it to? >>>>>>> >>>>>>> On 2. apr. 2010, at 01.33, esjewett@apache.org wrote: >>>>>>> >>>>>>>> Author: esjewett >>>>>>>> Date: Thu Apr =A01 23:33:10 2010 >>>>>>>> New Revision: 930136 >>>>>>>> >>>>>>>> URL: http://svn.apache.org/viewvc?rev=3D930136&view=3Drev >>>>>>>> Log: >>>>>>>> [ESME-187] Re-arrange input area so that the flow is a little bett= er - >>>>>>> this is a bit of an experiment - feel free to back out >>>>>>>> >>>>>>>> Modified: >>>>>>>> =A0incubator/esme/trunk/server/src/main/webapp/style/style.css >>>>>>>> >>>>>>> >>>>> incubator/esme/trunk/server/src/main/webapp/templates-hidden/message.= html >>>>>>>> >>>>>>>> Modified: incubator/esme/trunk/server/src/main/webapp/style/style.= css >>>>>>>> URL: >>>>>>> >>>>> http://svn.apache.org/viewvc/incubator/esme/trunk/server/src/main/web= app/style/style.css?rev=3D930136&r1=3D930135&r2=3D930136&view=3Ddiff >>>>>>>> >>>>>>> >>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>>>>>>> --- incubator/esme/trunk/server/src/main/webapp/style/style.css >>>>>>> (original) >>>>>>>> +++ incubator/esme/trunk/server/src/main/webapp/style/style.css Th= u Apr >>>>>>> 1 23:33:10 2010 >>>>>>>> @@ -192,10 +192,15 @@ label { >>>>>>>> } >>>>>>>> .login-btn, .update-btn, .submit-btn { >>>>>>>> =A0 =A0 float:right; >>>>>>>> -} >>>>>>>> +} >>>>>>>> +.share-select { >>>>>>>> + =A0 =A0 float:left; >>>>>>>> +} >>>>>>>> .update-btn { >>>>>>>> - =A0 =A0 margin-top:20px; >>>>>>>> - =A0 =A0 padding-top:10px; >>>>>>>> + =A0 =A0 margin-right:40px; >>>>>>>> +} >>>>>>>> +.update-btn, .share-select { >>>>>>>> + =A0 =A0 margin-top:10px; >>>>>>>> } >>>>>>>> #form-update label { >>>>>>>> =A0 =A0 font-weight:bold; >>>>>>>> @@ -216,7 +221,7 @@ textarea.inputBox2 { >>>>>>>> =A0 =A0 float:left; >>>>>>>> =A0 =A0 background-color:#FFFFFF !important; >>>>>>>> =A0 =A0 border:1px solid #a7aaad; >>>>>>>> - =A0 =A0 width:440px; >>>>>>>> + =A0 =A0 width:95%; >>>>>>>> =A0 =A0 height:50px; >>>>>>>> =A0 =A0 padding:4px; >>>>>>>> =A0 =A0 margin-right:10px;color:#000; >>>>>>>> @@ -532,7 +537,7 @@ h5 { font-size: 100%; } >>>>>>>> h6 { font-size: 80%; } >>>>>>>> img, img a {border:0px; } >>>>>>>> >>>>>>>> -.clear {clear:both; height:20px; } >>>>>>>> +.clear {clear:both;} >>>>>>>> >>>>>>>> /* >>>>>>>> .container-update, .container-tabs, .container-settings {behavior: >>>>>>> url("src/iepngfix.htc");} >>>>>>>> >>>>>>>> Modified: >>>>>>> >>>>> incubator/esme/trunk/server/src/main/webapp/templates-hidden/message.= html >>>>>>>> URL: >>>>>>> >>>>> http://svn.apache.org/viewvc/incubator/esme/trunk/server/src/main/web= app/templates-hidden/message.html?rev=3D930136&r1=3D930135&r2=3D930136&view= =3Ddiff >>>>>>>> >>>>>>> >>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>>>>>>> --- >>>>>>> >>>>> incubator/esme/trunk/server/src/main/webapp/templates-hidden/message.= html >>>>>>> (original) >>>>>>>> +++ >>>>>>> >>>>> incubator/esme/trunk/server/src/main/webapp/templates-hidden/message.= html >>>>>>> Thu Apr =A01 23:33:10 2010 >>>>>>>> @@ -26,29 +26,30 @@ >>>>>>>> >>>>>>> ui_messages_message_label_message_request >>>>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 >>>>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0
>>>>>>>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0
>>>>>>>> - >>>>>>>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0
>>>>>>>> - >>>>>>> >>>>>>>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 >>>>>>>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0
>>>>>>>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0
>>>>>> style=3D"display: none" id=3D"reply-to-div"> >>>>>>>> - >>>>>>> ui_messages_message_label_message_reply >>>>>>>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0>>>>>> id=3D"reply-to-span">- >>>>>>>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0>>>>>> clearReplyTo()"> >>>>>>>> - >>>>>>> ui_messages_message_label_message_remove_reply >>>>>>>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 >>>>>>>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0
>>>>>>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0
>>>>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0
>>>>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 >>>>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0
>>>>>> style=3D"display: none"> >>>>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 >>>>>> style=3D"width: 90%"/> >>>>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0
>>>>>>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0
>>>>>>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0
>>>>>> style=3D"display: none" id=3D"reply-to-div"> >>>>>>>> + >>>>>>> ui_messages_message_label_message_reply >>>>>>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0- >>>>>>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 >>>>>>>> + >>>>>>> ui_messages_message_label_message_remove_reply >>>>>>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 >>>>>>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0
>>>>>>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0
>>>>>>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0
>>>> class=3D"share-select"> >>>>>>>> + >>>>>>> >>>>>>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 >>>>>>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0
>>>>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0
>>>>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 >>>> type=3D"image" >>>>>>> onclick=3D"javascript:post_msg();" src=3D"images/btn-update.gif" /> >>>>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0
>>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>> >>>>> >>> >>> > >