incubator-esme-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ethan Jewett <esjew...@gmail.com>
Subject Re: svn commit: r930136 - in /incubator/esme/trunk/server/src/main/webapp: style/style.css templates-hidden/message.html
Date Tue, 06 Apr 2010 20:29:03 GMT
Thanks for doing this! I guess I'd leave it open until we have a more
permanent fix, but maybe lower the "badness" of the issue and make a
note of why that is happening?

I'm actually starting to think that the best way to do this is to have
the javascript that populates the message text that is being replied
to truncate that text to 140 characters (or something). The user just
needs a sample and JS has easy functions for doing this. Hmmm. Maybe
tonight.

What do you think? Do we want truncation or stretching as our final
fix for this issue?

Ethan


On Tue, Apr 6, 2010 at 3:58 PM, Anne Kathrine Petterøe
<yojibee@gmail.com> wrote:
> If we encourage our users not to use more than 140 characters (which I always thought
we should) - we are now safe. Shall I leave the ticket open as this is a bit of a quick fix,
seeing we haven't imposed any limits for how long the messages can be. (yet)
>
> /Anne
>
>
> On 4. apr. 2010, at 01.44, Ethan Jewett wrote:
>
>> Hi,
>>
>> I already opened ESME-188 for this issue (the input area expanding) -
>> https://issues.apache.org/jira/browse/ESME-188
>>
>> I don't think we need to move anything. Instead, we either need to
>> restrict the total length of the "reply to" section to only display
>> part of the message being replied to, or we need to make the input
>> area background expand dynamically to accomodate varied message
>> lengths.
>>
>> Ethan
>>
>> On Sat, Apr 3, 2010 at 11:01 AM, Anne Kathrine Petterøe
>> <yojibee@gmail.com> wrote:
>>> I'll take a look at it tomorrow.
>>> We could also make the update box background a bit longer too.
>>>
>>> On 3. apr. 2010, at 18.57, Richard Hirsch wrote:
>>>
>>>> Maybe it was some other tool.  Smaller font and other color (grey?) might
be
>>>> one option
>>>>
>>>> On Sat, Apr 3, 2010 at 6:55 PM, Anne Kathrine Petterøe <yojibee@gmail.com>wrote:
>>>>
>>>>> I will take a look at it during tomorrow's daily UI hour, but smaller
font
>>>>> might be one solution.
>>>>> twitter doesn't display the "reply to:" at all and brizzly displays an
>>>>> reply to box inline.
>>>>>
>>>>>
>>>>> On 3. apr. 2010, at 18.52, Richard Hirsch wrote:
>>>>>
>>>>>> let's look at how twitter / brizzly do it. They use a smaller font.
>>>>>>
>>>>>> On Sat, Apr 3, 2010 at 6:07 PM, Anne Kathrine Petterøe <
>>>>> yojibee@gmail.com>wrote:
>>>>>>
>>>>>>> I like it :-)
>>>>>>>
>>>>>>> Now sort of unrelated.
>>>>>>> I think we need to move the "reply to" function, as it currently
is it
>>>>>>> pushes the Share with and Update button out of the "what are
you working
>>>>> on"
>>>>>>> box. Where should we move it to?
>>>>>>>
>>>>>>> On 2. apr. 2010, at 01.33, esjewett@apache.org wrote:
>>>>>>>
>>>>>>>> Author: esjewett
>>>>>>>> Date: Thu Apr  1 23:33:10 2010
>>>>>>>> New Revision: 930136
>>>>>>>>
>>>>>>>> URL: http://svn.apache.org/viewvc?rev=930136&view=rev
>>>>>>>> Log:
>>>>>>>> [ESME-187] Re-arrange input area so that the flow is a little
better -
>>>>>>> this is a bit of an experiment - feel free to back out
>>>>>>>>
>>>>>>>> Modified:
>>>>>>>>  incubator/esme/trunk/server/src/main/webapp/style/style.css
>>>>>>>>
>>>>>>>
>>>>> incubator/esme/trunk/server/src/main/webapp/templates-hidden/message.html
>>>>>>>>
>>>>>>>> Modified: incubator/esme/trunk/server/src/main/webapp/style/style.css
>>>>>>>> URL:
>>>>>>>
>>>>> http://svn.apache.org/viewvc/incubator/esme/trunk/server/src/main/webapp/style/style.css?rev=930136&r1=930135&r2=930136&view=diff
>>>>>>>>
>>>>>>>
>>>>> ==============================================================================
>>>>>>>> --- incubator/esme/trunk/server/src/main/webapp/style/style.css
>>>>>>> (original)
>>>>>>>> +++ incubator/esme/trunk/server/src/main/webapp/style/style.css
Thu Apr
>>>>>>> 1 23:33:10 2010
>>>>>>>> @@ -192,10 +192,15 @@ label {
>>>>>>>> }
>>>>>>>> .login-btn, .update-btn, .submit-btn {
>>>>>>>>     float:right;
>>>>>>>> -}
>>>>>>>> +}
>>>>>>>> +.share-select {
>>>>>>>> +     float:left;
>>>>>>>> +}
>>>>>>>> .update-btn {
>>>>>>>> -     margin-top:20px;
>>>>>>>> -     padding-top:10px;
>>>>>>>> +     margin-right:40px;
>>>>>>>> +}
>>>>>>>> +.update-btn, .share-select {
>>>>>>>> +     margin-top:10px;
>>>>>>>> }
>>>>>>>> #form-update label {
>>>>>>>>     font-weight:bold;
>>>>>>>> @@ -216,7 +221,7 @@ textarea.inputBox2 {
>>>>>>>>     float:left;
>>>>>>>>     background-color:#FFFFFF !important;
>>>>>>>>     border:1px solid #a7aaad;
>>>>>>>> -     width:440px;
>>>>>>>> +     width:95%;
>>>>>>>>     height:50px;
>>>>>>>>     padding:4px;
>>>>>>>>     margin-right:10px;color:#000;
>>>>>>>> @@ -532,7 +537,7 @@ h5 { font-size: 100%; }
>>>>>>>> h6 { font-size: 80%; }
>>>>>>>> img, img a {border:0px; }
>>>>>>>>
>>>>>>>> -.clear {clear:both; height:20px; }
>>>>>>>> +.clear {clear:both;}
>>>>>>>>
>>>>>>>> /*
>>>>>>>> .container-update, .container-tabs, .container-settings {behavior:
>>>>>>> url("src/iepngfix.htc");}
>>>>>>>>
>>>>>>>> Modified:
>>>>>>>
>>>>> incubator/esme/trunk/server/src/main/webapp/templates-hidden/message.html
>>>>>>>> URL:
>>>>>>>
>>>>> http://svn.apache.org/viewvc/incubator/esme/trunk/server/src/main/webapp/templates-hidden/message.html?rev=930136&r1=930135&r2=930136&view=diff
>>>>>>>>
>>>>>>>
>>>>> ==============================================================================
>>>>>>>> ---
>>>>>>>
>>>>> incubator/esme/trunk/server/src/main/webapp/templates-hidden/message.html
>>>>>>> (original)
>>>>>>>> +++
>>>>>>>
>>>>> incubator/esme/trunk/server/src/main/webapp/templates-hidden/message.html
>>>>>>> Thu Apr  1 23:33:10 2010
>>>>>>>> @@ -26,29 +26,30 @@
>>>>>>>>
>>>>>>> <lift:loc>ui_messages_message_label_message_request</lift:loc>
>>>>>>>>                             </h3>
>>>>>>>>                             <div id="form-update">
>>>>>>>> -                                      <div
id="messages"></div>
>>>>>>>> -
>>>>>>>> -                                     <div
class="post-form-row">
>>>>>>>> -
>>>>>>> <label><lift:loc>ui_messages_share</lift:loc></label>
>>>>>>>> -                                      
      <select id="vPool"
>>>>>>> class="inputBox2">
>>>>>>>> -                                      
              <option
>>>>> value="0">
>>>>>>>> -
>>>>>>> <lift:loc>ui_messages_message_label_message_pool_public</lift:loc>
>>>>>>>> -                                      
              </option>
>>>>>>>> -
>>>>>>> <lift:UserSnip.accessPools/>
>>>>>>>> -                                      
      </select>
>>>>>>>> -                                     </div>
>>>>>>>> -                                     <div
class="row clear"
>>>>>>> style="display: none" id="reply-to-div">
>>>>>>>> -
>>>>>>> <b><lift:loc>ui_messages_message_label_message_reply</lift:loc></b>
>>>>>>>> -                                      
     <span
>>>>>>> id="reply-to-span">-</span>
>>>>>>>> -                                      
     <a href="javascript:
>>>>>>> clearReplyTo()">
>>>>>>>> -
>>>>>>> <lift:loc>ui_messages_message_label_message_remove_reply</lift:loc>
>>>>>>>> -                                      
     </a>
>>>>>>>> -                                      
 </div>
>>>>>>>> +                                     <div
id="messages"></div>
>>>>>>>>                                     <div
class="post-form-row">
>>>>>>>>                                      
      <textarea
>>>>> class="inputBox2"
>>>>>>> id="vMsg" rows="5" cols="80%"></textarea>
>>>>>>>>                                      
      <div class="row clear"
>>>>>>> style="display: none">
>>>>>>>>                                      
              <input id="vTag"
>>>>>>> style="width: 90%"/>
>>>>>>>>                                      
      </div>
>>>>>>>> +                                     </div>
>>>>>>>> +                                     <div
class="row clear"
>>>>>>> style="display: none" id="reply-to-div">
>>>>>>>> +
>>>>>>> <b><lift:loc>ui_messages_message_label_message_reply</lift:loc></b>
>>>>>>>> +                        <span id="reply-to-span">-</span>
>>>>>>>> +                        <a href="javascript:
clearReplyTo()">
>>>>>>>> +
>>>>>>> <lift:loc>ui_messages_message_label_message_remove_reply</lift:loc>
>>>>>>>> +                        </a>
>>>>>>>> +                    </div>
>>>>>>>> +                                     <div
class="post-form-row">
>>>>>>>> +                                      
      <div
>>>>> class="share-select">
>>>>>>>> +
>>>>>>> <label><lift:loc>ui_messages_share</lift:loc></label>
>>>>>>>> +                                      
              <select
>>>>> id="vPool"
>>>>>>> class="inputBox2">
>>>>>>>> +                                      
                      <option
>>>>>>> value="0">
>>>>>>>> +
>>>>>>> <lift:loc>ui_messages_message_label_message_pool_public</lift:loc>
>>>>>>>> +                                      
                      </option>
>>>>>>>> +
>>>>>>> <lift:UserSnip.accessPools/>
>>>>>>>> +                                      
              </select>
>>>>>>>> +                                      
      </div>
>>>>>>>>                                      
      <div class="update-btn">
>>>>>>>>                                      
              <input
>>>>> type="image"
>>>>>>> onclick="javascript:post_msg();" src="images/btn-update.gif"
/>
>>>>>>>>                                      
      </div>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>
>>>>>
>>>
>>>
>
>

Mime
View raw message