Mailing-List: contact esme-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: esme-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of hirsch.dick@gmail.com
 designates 209.85.218.210 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=BbvWggWRw3nABYkRzp7oIyYKAyOGNNzShSbhrZlYc3hurz4CjlNmSOsuEeso05+fJs
         EWa42SV7/bibNDUv7qA3REl+raWRDw+I91Ghn0SNjOIcPIuSilG5yaXLXN5PQOuyP4z/
         guU7hp6iCtZqvaRg3WRVpmgZy5wIsrlAc9bvA=
MIME-Version: 1.0
In-Reply-To: <68f4a0e81001030752g34ddd6wf64290ddd9226e93@mail.gmail.com>
References: <68f4a0e81001030752g34ddd6wf64290ddd9226e93@mail.gmail.com>
Date: Sun, 3 Jan 2010 17:01:34 +0100
Message-ID: <fa2d9f451001030801h7ed365a6yd1993fa4e4ae8c81@mail.gmail.com>
Subject: Re: Posting message to pool strips tags - Bug?
From: Richard Hirsch <hirsch.dick@gmail.com>
To: esme-dev@incubator.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Doesn't make much sense to me.

Probably Vassil knows the reason why this code is present since the
pool is code is from him.

D.


On Sun, Jan 3, 2010 at 4:52 PM, Ethan Jewett <esjewett@gmail.com> wrote:
> Hi,
>
> I've got Jira issue 151
> (https://issues.apache.org/jira/browse/ESME-151) created because Sig
> (Thingamy) is reporting issues posting messages to pools.
> Specifically, tags are stripped when posting to a pool.
>
> The reason is little code snippet in the UserActor.scala file:
>
> =A0 =A0 =A0 =A0val tagLst =3D pool match {
> =A0 =A0 =A0 =A0 =A0case Empty =3D> tags.removeDuplicates.map(Tag.findOrCr=
eate)
> =A0 =A0 =A0 =A0 =A0case _ =3D> Nil
> =A0 =A0 =A0 =A0}
>
> It removes tags when a message is posted to a pool.
>
> Is there here for a reason? Is there a security reason? It's
> definitely something we need to fix, but I want to be sure that I'm
> not exposing messages in a pool through the tag UI.
>
> I think I will go ahead and fix this so that Sig can continue, but if
> there is something else that needs to be adjusted, please let me know
> and I'll work on that as well.
>
> Thanks,
> Ethan
>