incubator-esme-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Richard Hirsch <hirsch.d...@gmail.com>
Subject Re: [New Contributor]Where do I submit patch?
Date Mon, 28 Sep 2009 12:40:10 GMT
I'll wait to add your ESME-72 code until you have finished the
ESME-84-related code. Otherwise, I wouldn't be able to test it.

D.

On Mon, Sep 28, 2009 at 2:21 PM, Xuefeng Wu <benewu@gmail.com> wrote:
> Thank you
>
> On Mon, Sep 28, 2009 at 7:42 PM, Vassil Dichev <vdichev@apache.org> wrote:
>
>> First of all, welcome to the team, Xuefeng! I hope you have fun.
>>
>> Yes, AccessPoolMgr is the right place to check and edit (Dick, you're
>> getting better with Scala!)
>>
>> Good luck,
>> Vassil
>>
>>
>> On Mon, Sep 28, 2009 at 2:22 PM, Richard Hirsch <hirsch.dick@gmail.com>
>> wrote:
>> > Yes take a look at "displayPoolUsers" in AccessPoolMgr.
>> >
>> > D.
>> >
>> > On Mon, Sep 28, 2009 at 1:06 PM, Xuefeng Wu <benewu@gmail.com> wrote:
>> >> The poolUsers snippet code is in AccessPoolMgr?
>> >>
>> >> On Mon, Sep 28, 2009 at 6:56 PM, Richard Hirsch <hirsch.dick@gmail.com
>> >wrote:
>> >>
>> >>> Part of the code is here:
>> >>> trunk\server\src\main\webapp\pools_view\index.html.
>> >>>
>> >>> Currently, the users for the poor are being added with this code:
>> >>>
>> >>>    <lift:poolUsers the_id="PoolSpan">
>> >>>      <table>
>> >>>        <thead>
>> >>>          <tr> <th>User</th>  <th>Privilege</th>
</tr>
>> >>>        </thead>
>> >>>
>> >>>        <tbody>
>> >>>          <pool:user>
>> >>>            <tr> <td><user:name/></td>
 <td><user:privilege/></td> </tr>
>> >>>          </pool:user>
>> >>>        </tbody>
>> >>>      </table>
>> >>>
>> >>> You have to have something similar (change HTML file and Scala code
>> >>> for the pool details.
>> >>>
>> >>> D.
>> >>>
>> >>> On Mon, Sep 28, 2009 at 12:52 PM, Xuefeng Wu <benewu@gmail.com>
wrote:
>> >>> > I think so, but I'm not sure which view for AccessPool.
>> >>> > org.apache.esme.view.UserView?
>> >>> >
>> >>> > On Mon, Sep 28, 2009 at 6:43 PM, Richard Hirsch <
>> hirsch.dick@gmail.com
>> >>> >wrote:
>> >>> >
>> >>> >> There is already a view for the AccesPools. I'd try to use
that as
>> >>> >> much as possible rather than putting any UI-related code in
the
>> >>> >> AccessPoolMgr.
>> >>> >>
>> >>> >> @vassil: what do you think?
>> >>> >>
>> >>> >> D.
>> >>> >>
>> >>> >> On Mon, Sep 28, 2009 at 11:42 AM, Xuefeng Wu <benewu@gmail.com>
>> wrote:
>> >>> >> > Maybe I find it.Should I place code at
>> >>> org.apache.esme.lib.AccessPoolMgr?
>> >>> >> >
>> >>> >> > On Mon, Sep 28, 2009 at 5:38 PM, Xuefeng Wu <benewu@gmail.com>
>> wrote:
>> >>> >> >
>> >>> >> >> Should we have a new snippet or view  for AcessPool?
>> >>> >> >> I'm not sure where could place the bind code for display
>> AcessPoll
>> >>> >> detail.
>> >>> >> >>
>> >>> >> >>
>> >>> >> >> P.S. I submit a new patch for ESME-72, please replay
the new one
>> if
>> >>> you
>> >>> >> >> download before,  and I deleted the old patch file
for ignoring
>> >>> confuse.
>> >>> >> >>
>> >>> >> >>
>> >>> >> >> On Mon, Sep 28, 2009 at 3:14 PM, Richard Hirsch <
>> >>> hirsch.dick@gmail.com
>> >>> >> >wrote:
>> >>> >> >>
>> >>> >> >>> Looks good.
>> >>> >> >>>
>> >>> >> >>> I'll test it on the stax deployment.
>> >>> >> >>>
>> >>> >> >>> I've added a new JIRA item
>> >>> >> >>> (https://issues.apache.org/jira/browse/ESME-84)
to display the
>> new
>> >>> >> >>> values in the UI. Why don't you take a crack at
them. It doesn't
>> ave
>> >>> >> >>> to be pretty (that will come later) just functional.
>> >>> >> >>>
>> >>> >> >>> D.
>> >>> >> >>>
>> >>> >> >>> On Mon, Sep 28, 2009 at 8:14 AM, Xuefeng Wu <benewu@gmail.com>
>> >>> wrote:
>> >>> >> >>> > Thank you !
>> >>> >> >>> >
>> >>> >> >>> > I'm in Shanghai now.
>> >>> >> >>> >
>> >>> >> >>> > On Mon, Sep 28, 2009 at 1:58 PM, J Aaron
Farr <
>> farra@apache.org>
>> >>> >> wrote:
>> >>> >> >>> >
>> >>> >> >>> >> On Mon 28 Sep 2009 13:01, Xuefeng Wu
<benewu@gmail.com>
>> wrote:
>> >>> >> >>> >>
>> >>> >> >>> >> > I write some code for ESME-72, but
I don't know where
>> should I
>> >>> >> >>> submit?
>> >>> >> >>> >> >
>> >>> >> >>> >> > The attachment is the patch file,
Thanks!
>> >>> >> >>> >>
>> >>> >> >>> >>
>> >>> >> >>> >> 0. If you don't have a JIRA account,
create one here:
>> >>> >> >>> >>
>> >>> >> >>> >>   https://issues.apache.org/jira/secure/Signup!default.jspa
>> >>> >> >>> >>
>> >>> >> >>> >> 1. Go to the ESME-72 issue page:
>> >>> >> >>> >>
>> >>> >> >>> >>   https://issues.apache.org/jira/browse/ESME-72
>> >>> >> >>> >>
>> >>> >> >>> >> 2. Click the "Attach file to this issue"
link on the left
>> side.
>> >>> >> >>> >>
>> >>> >> >>> >> 3. Attach your patch, include a comment,
make sure you click:
>> >>> >> >>> >>
>> >>> >> >>> >>   "Grant license to ASF for inclusion
in ASF works (as per
>> the
>> >>> >> Apache
>> >>> >> >>> >>   License §5)"
>> >>> >> >>> >>
>> >>> >> >>> >> If you have any trouble, please let us
know.
>> >>> >> >>> >>
>> >>> >> >>> >>
>> >>> >> >>> >> Where are you in China?  I'm currently
in Guangzhou.
>> >>> >> >>> >>
>> >>> >> >>> >> --
>> >>> >> >>> >>   J. Aaron Farr
>> >>> >> >>> >>   馮傑仁
>> >>> >> >>> >>   www.cubiclemuses.com
>> >>> >> >>> >>
>> >>> >> >>> >
>> >>> >> >>> >
>> >>> >> >>> >
>> >>> >> >>> > --
>> >>> >> >>> > Global R&D Center,Shanghai China,Carestream
Health, Inc.
>> >>> >> >>> > Tel:(86-21)3852 6101
>> >>> >> >>> >
>> >>> >> >>>
>> >>> >> >>
>> >>> >> >>
>> >>> >> >>
>> >>> >> >> --
>> >>> >> >> Global R&D Center,Shanghai China,Carestream Health,
Inc.
>> >>> >> >> Tel:(86-21)3852 6101
>> >>> >> >>
>> >>> >> >
>> >>> >> >
>> >>> >> >
>> >>> >> > --
>> >>> >> > Global R&D Center,Shanghai China,Carestream Health,
Inc.
>> >>> >> > Tel:(86-21)3852 6101
>> >>> >> >
>> >>> >>
>> >>> >
>> >>> >
>> >>> >
>> >>> > --
>> >>> > Global R&D Center,Shanghai China,Carestream Health, Inc.
>> >>> > Tel:(86-21)3852 6101
>> >>> >
>> >>>
>> >>
>> >>
>> >>
>> >> --
>> >> Global R&D Center,Shanghai China,Carestream Health, Inc.
>> >> Tel:(86-21)3852 6101
>> >>
>> >
>>
>
>
>
> --
> Global R&D Center,Shanghai China,Carestream Health, Inc.
> Tel:(86-21)3852 6101
>

Mime
View raw message