Return-Path: X-Original-To: apmail-incubator-empire-db-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-empire-db-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BA1E28FE9 for ; Tue, 16 Aug 2011 20:16:05 +0000 (UTC) Received: (qmail 63887 invoked by uid 500); 16 Aug 2011 20:16:05 -0000 Delivered-To: apmail-incubator-empire-db-dev-archive@incubator.apache.org Received: (qmail 63875 invoked by uid 500); 16 Aug 2011 20:16:05 -0000 Mailing-List: contact empire-db-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: empire-db-dev@incubator.apache.org Delivered-To: mailing list empire-db-dev@incubator.apache.org Received: (qmail 63867 invoked by uid 99); 16 Aug 2011 20:16:05 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Aug 2011 20:16:05 +0000 X-ASF-Spam-Status: No, hits=1.6 required=5.0 tests=RCVD_IN_BRBL_LASTEXT,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [88.79.172.157] (HELO mail.esteam.de) (88.79.172.157) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Aug 2011 20:16:00 +0000 Content-class: urn:content-classes:message Subject: re: EMPIRE-99 merge to trunk? MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Date: Tue, 16 Aug 2011 22:16:05 +0200 Message-ID: X-MimeOLE: Produced By Microsoft Exchange V6.5 In-Reply-To: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: re: EMPIRE-99 merge to trunk? thread-index: AcxcKWYaM2Q84wUAQ426lZnnuojfMAAJ8QeA References: From: =?iso-8859-1?Q?Rainer_D=F6bele?= To: Thanks Francis, you're a star (as always!) Rainer > from: Francis De Brabandere [mailto:francisdb@gmail.com] > to: empire-db-dev@incubator.apache.org > re: Re: EMPIRE-99 merge to trunk? >=20 > I already fixed the examples an the codegen. I'll take care of the > merge. >=20 > Cheers, > Francis >=20 > On Tue, Aug 16, 2011 at 5:02 PM, Rainer D=F6bele > wrote: > > Hi Franics, > > > > thanks. I noticed the StringUtils issue - but needed a break. > > It's a matter of taste what the String representation of null should > be, and I am not sure whether I really want to keep it like this. > > For logging the value "null" is certainly better whereas for all > other purposes an empty string is preferable. > > > > Most of the work for EMPIREDB-99 has been done. > > Only the codegen and three sample projects are missing but should be > quite straigt forward to migrate. > > > > I have not been able to do a lot of testing, but I am confident that > most code will work as before. > > > > I would appreciate a merge with the trunk and Francis if you want to > do this, then please go ahead. > > > > I won't perform any more changes today. > > > > Regards > > Rainer > > > > > >> from: Francis De Brabandere [mailto:francisdb@gmail.com] > >> to: empire-db-dev@incubator.apache.org > >> re: EMPIRE-99 merge to trunk? > >> > >> There is one issue left causing a StringutilsTest to fail: > >> > >> this used to return empty string but now return "null" > >> assertEquals("null",StringUtils.valueOf(null)); > >> > >> This used to return empty string but is now "null" > >> assertEquals("null",StringUtils.valueOf(new Object[]{})); > >> > >> I changed the test to accept the new behavior but this is dangerous > in > >> my eyes as this StringUtils is public and we might break existing > >> code. > >> > >> Thanks Rainer for taking care of most of the refactorings, great we > >> got there! So shall we merge the branch to trunk now? > >> > >> Greets, > >> Francis > >> > >> -- > >> http://www.somatik.be > >> Microsoft gives you windows, Linux gives you the whole house. > > >=20 >=20 >=20 > -- > http://www.somatik.be > Microsoft gives you windows, Linux gives you the whole house.