Mailing-List: contact empire-db-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: empire-db-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of francisdb@gmail.com designates
 209.85.212.47 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :content-type:content-transfer-encoding;
        b=bV4Sc1WbZ8keycHje8SCMG6KdvvKKXk7wfPX+K12T0LhZrwNJE6EUU6IxawMFmfh8k
         yZOPidknQ7nM2bl7hDdTOVeVPnpfh8nAOWZiAZeZ1Qg50Xs3yNyPTj8t0fCfeDvcHhSX
         JM12rCkOCfkmgUnEv6ox7/4VSLfoWrPCni3eg=
MIME-Version: 1.0
In-Reply-To: <AANLkTim3HnRsnKCE3T0n5ER7bFqy3Ajbh8LA7CwJcK=H@mail.gmail.com>
References: <AANLkTind9vc46f=NYXoA2forx2YgUoAkAs=iFFemt1Ru@mail.gmail.com>
 <B297D4737108A0459B66C3A85BB7F90127C694@kn.esteam.de>
 <0558C595-598F-4CA5-8082-1BE3277092DC@andreasfink.com>
 <AANLkTim3HnRsnKCE3T0n5ER7bFqy3Ajbh8LA7CwJcK=H@mail.gmail.com>
From: Francis De Brabandere <francisdb@gmail.com>
Date: Mon, 11 Oct 2010 08:32:24 +0200
Message-ID: <AANLkTin=Y+6nRJzbe_zmaYE+r5WvQ-Co3wowzkdSZq2W@mail.gmail.com>
Subject: Re: AW: year "functionName" for Oracle
To: empire-db-dev@incubator.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 11, 2010 at 1:19 AM, Marcio Mazza <marciomazza@gmail.com> wrote=
:
> Thanks for the answer, Rainer.
>
> Maybe I should clarify that the little test was just for
> communication, and not to actually test functionality.
>
> The concern is that the method
> =A0String org.apache.empire.db.expr.column.DBFuncExpr.getFunctionName()
> =A0is used by
> =A0 =A0Element org.apache.empire.db.expr.column.DBAbstractFuncExpr.addXml=
(Element
> parent, long flags)
> =A0 =A0which is used by
> =A0 =A0 =A0boolean org.apache.empire.db.DBReader.addColumnDesc(Element pa=
rent)
> =A0 =A0 =A0which is used by
> =A0 =A0 =A0 =A0Document org.apache.empire.db.DBReader.getXmlDocument()
>
> so maybe we may end up having something unexpected with the XML
> generation. I really dunno. I'm still reading the codebase.
>
> By the way, I really think that the project should have more tests,
> some of which would be integration tests, indeed.

I agree, feel free to submit some in jira

>
>
>
> 2010/10/10 Andreas Fink <andi@andreasfink.com>:
>> oracle? never heard of ;-)
>>
>>> So since I am sure, that there are not many people using Oracle 8 or an=
 earlier version any more, I will change the default implementation for the=
 date extraction functions
>> [...]
>>> compatibility.
>>> Does anyone have concerns about this?
>>
>> +1 for the change
>>
>> regards,
>> andi
>>
>>
>> --
>> web: =A0 http://andreasfink.com/
>> mail: =A0af@andreasfink.com
>> mobil: +34 65 1728443
>> tel: =A0 +34 93 2082949
>>
>>
>


--=20
http://www.somatik.be
Microsoft gives you windows, Linux gives you the whole house.