incubator-empire-db-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Francis De Brabandere <franci...@gmail.com>
Subject Re: AW: year "functionName" for Oracle
Date Mon, 11 Oct 2010 06:32:24 GMT
On Mon, Oct 11, 2010 at 1:19 AM, Marcio Mazza <marciomazza@gmail.com> wrote:
> Thanks for the answer, Rainer.
>
> Maybe I should clarify that the little test was just for
> communication, and not to actually test functionality.
>
> The concern is that the method
>  String org.apache.empire.db.expr.column.DBFuncExpr.getFunctionName()
>  is used by
>    Element org.apache.empire.db.expr.column.DBAbstractFuncExpr.addXml(Element
> parent, long flags)
>    which is used by
>      boolean org.apache.empire.db.DBReader.addColumnDesc(Element parent)
>      which is used by
>        Document org.apache.empire.db.DBReader.getXmlDocument()
>
> so maybe we may end up having something unexpected with the XML
> generation. I really dunno. I'm still reading the codebase.
>
> By the way, I really think that the project should have more tests,
> some of which would be integration tests, indeed.

I agree, feel free to submit some in jira

>
>
>
> 2010/10/10 Andreas Fink <andi@andreasfink.com>:
>> oracle? never heard of ;-)
>>
>>> So since I am sure, that there are not many people using Oracle 8 or an earlier
version any more, I will change the default implementation for the date extraction functions
>> [...]
>>> compatibility.
>>> Does anyone have concerns about this?
>>
>> +1 for the change
>>
>> regards,
>> andi
>>
>>
>> --
>> web:   http://andreasfink.com/
>> mail:  af@andreasfink.com
>> mobil: +34 65 1728443
>> tel:   +34 93 2082949
>>
>>
>



-- 
http://www.somatik.be
Microsoft gives you windows, Linux gives you the whole house.

Mime
View raw message