Return-Path: Delivered-To: apmail-incubator-empire-db-dev-archive@minotaur.apache.org Received: (qmail 84457 invoked from network); 6 Dec 2009 00:03:20 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 6 Dec 2009 00:03:20 -0000 Received: (qmail 6169 invoked by uid 500); 6 Dec 2009 00:03:20 -0000 Delivered-To: apmail-incubator-empire-db-dev-archive@incubator.apache.org Received: (qmail 6142 invoked by uid 500); 6 Dec 2009 00:03:20 -0000 Mailing-List: contact empire-db-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: empire-db-dev@incubator.apache.org Delivered-To: mailing list empire-db-dev@incubator.apache.org Received: (qmail 6131 invoked by uid 99); 6 Dec 2009 00:03:20 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 06 Dec 2009 00:03:20 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [217.72.192.227] (HELO fmmailgate02.web.de) (217.72.192.227) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 06 Dec 2009 00:03:12 +0000 Received: from smtp08.web.de (fmsmtp08.dlan.cinetic.de [172.20.5.216]) by fmmailgate02.web.de (Postfix) with ESMTP id 04C39146E222E for ; Sun, 6 Dec 2009 01:02:52 +0100 (CET) Received: from [84.114.51.59] (helo=[192.168.0.146]) by smtp08.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.110 #314) id 1NH4aR-0004g7-00 for empire-db-dev@incubator.apache.org; Sun, 06 Dec 2009 01:02:51 +0100 Message-ID: <4B1AF4BC.40008@web.de> Date: Sun, 06 Dec 2009 01:03:08 +0100 From: Benjamin Venditti User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: empire-db-dev@incubator.apache.org Subject: Re: addColumn() but no addTable() References: <3ab983230912031519w42e553e7r906cc84053cf8686@mail.gmail.com> In-Reply-To: <3ab983230912031519w42e553e7r906cc84053cf8686@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: benniven@web.de X-Sender: benniven@web.de X-Provags-ID: V01U2FsdGVkX19HFR77hSxs5uAyJkTW7Ep7IJJfuu7vZBEBVJ3j T1Hy/tiMZ8eQafr2GjpxFMvMeYUEeV3heVGG4LpV6b2hRSV6FH VeqniC8EY= X-Virus-Checked: Checked by ClamAV on apache.org Hi there, so currently there are two main issues: - relations - handling database specific things i'll have a look on the relations soon, as i don't know where to start with handling the database specific things. @ Francis: >>I think it might be usefull to have addTable() on a DBDatabase. This makes everything a bit more consistent in my eyes. DBDatabase already has "addTable()" but by adding "addTable(String table)" it would really be more consistent. @ Rainer: I agree to remove the static accessor in the in the generated database, thus we make it a normal class instead of a singleton. And about the two generic methods on the generated database class i'm not sure what to do. Splitting the codegen into a writer and a parser almost only using DBDatabase objects was pretty straight forward. The only problem was that they don't cover accessor/mutator names but that could be solved with a additional ParserUtil class. Gladly it was even easier to implement the nested column classes :). best regard benjamin