incubator-droids-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Javier Puerto (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DROIDS-92) Externalize creation of Save handler from SaveCrawlingDroid so that the handler can be configured first
Date Sat, 14 Aug 2010 10:55:16 GMT

    [ https://issues.apache.org/jira/browse/DROIDS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898563#action_12898563
] 

Javier Puerto commented on DROIDS-92:
-------------------------------------

I was working on a patch to solve this in more generic form but I didn't have time to test
and commit it.

In previous revisions, the Droids has to be initialized with the handlers in a similar manner
as you propose but the problem was that the handler could not be thread safe so the results
can be unexpected. Now, the Workers must be declared with the handlers so every Worker has
own handler instance and avoid the thread safe problem but it's not very flexible due to the
need to create workers for each handler or handler group that you want to use. Is it  the
problem that you have?.

Please wait till the patch is finished so we can use the handlers in more generic form for
all the droids.

> Externalize creation of Save handler from SaveCrawlingDroid so that the handler can be
configured first
> -------------------------------------------------------------------------------------------------------
>
>                 Key: DROIDS-92
>                 URL: https://issues.apache.org/jira/browse/DROIDS-92
>             Project: Droids
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.0.1
>            Reporter: Eugen Paraschiv
>            Priority: Minor
>             Fix For: 0.0.1
>
>         Attachments: DROIDS-92.patch
>
>
> The Save handler is instantiated withing SaveCrawlingDroid and thus, the client has no
control over it - no way of setting properties on it and no way to inject another one. 
> As a solution, the Save handler should be injected into the SaveCrawlingDroid. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message