incubator-droids-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rfrov...@apache.org
Subject svn commit: r1211019 - /incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/impl/SimpleTaskQueueWithHistory.java
Date Tue, 06 Dec 2011 16:56:54 GMT
Author: rfrovarp
Date: Tue Dec  6 16:56:53 2011
New Revision: 1211019

URL: http://svn.apache.org/viewvc?rev=1211019&view=rev
Log:
Add a comment about order of operations

Modified:
    incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/impl/SimpleTaskQueueWithHistory.java

Modified: incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/impl/SimpleTaskQueueWithHistory.java
URL: http://svn.apache.org/viewvc/incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/impl/SimpleTaskQueueWithHistory.java?rev=1211019&r1=1211018&r2=1211019&view=diff
==============================================================================
--- incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/impl/SimpleTaskQueueWithHistory.java
(original)
+++ incubator/droids/trunk/droids-core/src/main/java/org/apache/droids/impl/SimpleTaskQueueWithHistory.java
Tue Dec  6 16:56:53 2011
@@ -61,6 +61,8 @@ public class SimpleTaskQueueWithHistory<
   {
     boolean hasChanged = false;
     for (T e : c) {
+      // Must be in this order otherwise the short circuiting or
+      // will make it so that items aren't added.
       hasChanged = this.add(e) || hasChanged;
     }
     return hasChanged;



Mime
View raw message