Return-Path: X-Original-To: apmail-incubator-directmemory-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-directmemory-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 90EC89F8F for ; Thu, 23 Feb 2012 16:01:20 +0000 (UTC) Received: (qmail 17685 invoked by uid 500); 23 Feb 2012 16:01:20 -0000 Delivered-To: apmail-incubator-directmemory-dev-archive@incubator.apache.org Received: (qmail 17647 invoked by uid 500); 23 Feb 2012 16:01:20 -0000 Mailing-List: contact directmemory-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: directmemory-dev@incubator.apache.org Delivered-To: mailing list directmemory-dev@incubator.apache.org Received: (qmail 17638 invoked by uid 99); 23 Feb 2012 16:01:20 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Feb 2012 16:01:20 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of benoit@noisette.ch designates 209.85.213.175 as permitted sender) Received: from [209.85.213.175] (HELO mail-yx0-f175.google.com) (209.85.213.175) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Feb 2012 16:01:13 +0000 Received: by yenr5 with SMTP id r5so664488yen.6 for ; Thu, 23 Feb 2012 08:00:52 -0800 (PST) Received-SPF: pass (google.com: domain of benoit@noisette.ch designates 10.60.12.103 as permitted sender) client-ip=10.60.12.103; Authentication-Results: mr.google.com; spf=pass (google.com: domain of benoit@noisette.ch designates 10.60.12.103 as permitted sender) smtp.mail=benoit@noisette.ch Received: from mr.google.com ([10.60.12.103]) by 10.60.12.103 with SMTP id x7mr644226oeb.51.1330012852898 (num_hops = 1); Thu, 23 Feb 2012 08:00:52 -0800 (PST) MIME-Version: 1.0 Received: by 10.60.12.103 with SMTP id x7mr573371oeb.51.1330012852732; Thu, 23 Feb 2012 08:00:52 -0800 (PST) Received: by 10.182.188.102 with HTTP; Thu, 23 Feb 2012 08:00:52 -0800 (PST) In-Reply-To: References: Date: Thu, 23 Feb 2012 17:00:52 +0100 Message-ID: Subject: Re: directmemory pull request: [DIRECTMEMORY-43] Cache should allow key objects instead of plain string From: Benoit Perroud To: directmemory-dev@incubator.apache.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Gm-Message-State: ALoCoQkigcHpLWi4Zq8Y6cOxur+5iQKQUMO5S/CcuxqyHaHQSveN+ftN0G5CMms4tEGUPzmnNWjb X-Virus-Checked: Checked by ClamAV on apache.org Hi All, I had a chance to go through the pull, it's a big +1. Thanks Simone ! Benoit. 2012/2/23 Tommaso Teofili : > I'm also offline for some days, +1 for pushing it in :) > Tommaso > > 2012/2/23 Olivier Lamy > >> Sorry I'm a bit off until saturday to have a look. >> So push it :-) >> >> -- >> Olivier >> Send from a vt100 phone terminal >> =C2=A0Le 23 f=C3=A9vr. 2012 13:19, "Simone Tripodi" a >> =C3=A9crit : >> >> > does anybody have feedbacks to provide? If no objection will be shown, >> > I'll assume lazy consensus... >> > >> > TIA, >> > -Simo >> > >> > http://people.apache.org/~simonetripodi/ >> > http://simonetripodi.livejournal.com/ >> > http://twitter.com/simonetripodi >> > http://www.99soft.org/ >> > >> > >> > >> > On Wed, Feb 22, 2012 at 10:31 PM, Git at Apache >> > wrote: >> > > GitHub user simonetripodi opened the pull request at >> > > https://github.com/apache/directmemory/pull/2 >> > > >> > > ---- >> > > [DIRECTMEMORY-43] Cache should allow key objects instead of plain >> string >> > > >> > > This is my proposal to change the DM signature from = to >> > . >> > > >> > > It contains some signatures modification. >> > > >> > > Please review! >> > > ---- >> > > >> > > You can merge this pull request into a Git repository by running >> > > $ git pull https://github.com/simonetripodi/directmemory trunk >> > > >> > > Alternatively you can review and apply these changes as the patch at >> > > https://github.com/apache/directmemory/pull/2.patch >> > >> --=20 sent from my Nokia 3210