incubator-directmemory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benoit Perroud <ben...@noisette.ch>
Subject Re: Code Formatting
Date Fri, 30 Dec 2011 12:05:15 GMT
absolutely +1

I don't care which code style, because it's like churchs, everyone
prefers it's own :)
It's up to you, commiters, to state on this point.


2011/12/30 Maurizio Cucchiara <mcucchiara@apache.org>:
> Hi all,
> before it is too late, we should take a decision at this point, the
> code in terms of formatting is going to become a big mess.
> I personally saw at least 3 different kinds of code styles.
> I'd strongly advise to use maven code style (though I'm not nuts about
> it) and configure maven checkstyle plugin.
> WDYT?
>
>
> Twitter     :http://www.twitter.com/m_cucchiara
> G+          :https://plus.google.com/107903711540963855921
> Linkedin    :http://www.linkedin.com/in/mauriziocucchiara
>
> Maurizio Cucchiara
>
>
>
> On 21 October 2011 21:30, Raffaele P. Guidi <raffaele.p.guidi@gmail.com> wrote:
>> I hate line breaks before curly braces - I couldn't stand it even in csharp
>> where it's the standard:
>>
>> public class MyMojo
>> {
>>
>>
>>
>> Also I find horrible and boring listing function names and parameters that
>> are (or should be) self explicable. Would find them disturbing even if they
>> were automatically generated - but could cope with that if needed
>>
>>    /**
>>     * Artifact factory.
>>     *
>>     * @component
>>     */
>>    private ArtifactFactory artifactFactory;
>>
>>
>>    // ----------------------------------------------------------------------
>>    // Mojo parameters
>>    // ----------------------------------------------------------------------
>>
>>    /**
>>     * The POM.
>>     *
>>     * @parameter expression="${project}"
>>     * @required
>>     */
>>
>>
>> Ok for everything else.
>>
>> Ciao,
>>    R
>>
>>
>> 2011/10/21 Akash Ashok <thehellmaker@gmail.com>
>>
>>> Along with the formatted for eclipse here's a link which defines the coding
>>> standards
>>>
>>> http://maven.apache.org/developers/conventions/code.html
>>>
>>> It would be nice if we could come to a consensus on the standards soon so
>>> that we dnt run into too much of maintenance issues.
>>>
>>> I would like to hear what every1 has to say about it.
>>>
>>> Cheers,
>>> Akash A
>>>
>>> 2011/10/21 Raffaele P. Guidi <raffaele.p.guidi@gmail.com>
>>>
>>> > Yes, nice feature. It's a team saver ;)
>>> >
>>> > On Thu, Oct 20, 2011 at 9:40 PM, Maurizio Cucchiara
>>> > <mcucchiara@apache.org>wrote:
>>> >
>>> > > Personally I don't like the maven code style, but I have to admit that
>>> > > I like the idea behind a ready-to-go-style.
>>> > >
>>> > >
>>> > > Twitter     :http://www.twitter.com/m_cucchiara
>>> > > G+          :https://plus.google.com/107903711540963855921
>>> > > Linkedin    :http://www.linkedin.com/in/mauriziocucchiara
>>> > >
>>> > > Maurizio Cucchiara
>>> > >
>>> > >
>>> > >
>>> > > 2011/10/20 Olivier Lamy <olamy@apache.org>:
>>> > > > Yup check provided files here
>>> > > > http://maven.apache.org/developers/committer-environment.html
>>> > > > Files exists for idea and eclipse.
>>> > > >
>>> > > >
>>> > > > 2011/10/20 Raffaele P. Guidi <raffaele.p.guidi@gmail.com>:
>>> > > >> I heard something like automated IDE setup of this? Is it
possible?
>>> > > >>
>>> > > >> On Thursday, October 20, 2011, Akash Ashok <thehellmaker@gmail.com>
>>> > > wrote:
>>> > > >>> +1 on spaces and -1 on tabs. :)  I'd personally prefer
2, but 4
>>> also
>>> > > >> sounds
>>> > > >>> good.
>>> > > >>>
>>> > > >>> Cheers,
>>> > > >>> Akash A
>>> > > >>>
>>> > > >>> On Thu, Oct 20, 2011 at 7:26 PM, Ioannis Canellos <
>>> iocanel@gmail.com
>>> > >
>>> > > >> wrote:
>>> > > >>>
>>> > > >>>> I don't like tabs either.
>>> > > >>>> I would also like to suggest using 4 spaces ident.
I think its the
>>> > > most
>>> > > >>>> common ident and will help a lot of us changing our
settings all
>>> the
>>> > > >> time.
>>> > > >>>>
>>> > > >>>> On 20 Οκτ 2011, at 4:52 μ.μ., Olivier Lamy wrote:
>>> > > >>>>
>>> > > >>>> > Agree something to be defined.
>>> > > >>>> > Perso I don't like tabs :-)
>>> > > >>>> >
>>> > > >>>> > I can propose the maven codestyle if you agree.
>>> > > >>>> > All files for ide are here
>>> > > >>>> > http://maven.apache.org/developers/committer-environment.html
>>> > > >>>> >
>>> > > >>>> > And a checktyle file is embeded in the maven
checktyle plugin.
>>> > > >>>> >
>>> > > >>>> > As you want folks
>>> > > >>>> >
>>> > > >>>> > 2011/10/20 Akash Ashok <thehellmaker@gmail.com>:
>>> > > >>>> >> I see that we use tabs at someplaces and
spaces someplace else
>>> > for
>>> > > >>>> >> indentation. Do we have a coding guideline
in place ?
>>> > > >>>> >> If not may be we need to get one in place
and have a consistent
>>> > > >>>> formatting
>>> > > >>>> >> across the entire codebase,
>>> > > >>>> >>
>>> > > >>>> >> Cheers,
>>> > > >>>> >> Akash A
>>> > > >>>> >>
>>> > > >>>> >
>>> > > >>>> >
>>> > > >>>> >
>>> > > >>>> > --
>>> > > >>>> > Olivier Lamy
>>> > > >>>> > Talend : http://talend.com
>>> > > >>>> > http://twitter.com/olamy | http://linkedin.com/in/olamy
>>> > > >>>>
>>> > > >>>>
>>> > > >>>
>>> > > >>
>>> > > >
>>> > > >
>>> > > >
>>> > > > --
>>> > > > Olivier Lamy
>>> > > > Talend : http://talend.com
>>> > > > http://twitter.com/olamy | http://linkedin.com/in/olamy
>>> > > >
>>> > >
>>> >
>>>



-- 
sent from my Nokia 3210

Mime
View raw message