incubator-directmemory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Olivier Lamy <ol...@apache.org>
Subject Re: refactoring in a branch
Date Sat, 26 Nov 2011 08:29:35 GMT
yup use agree create a branch and commit on it.
Like a *git* workflow. (raffaele github is a private company not a scm
tool it's very different ! )
As it everybody will se that.
You can do it now directly in svn (or tru git svn).


2011/11/26 Raffaele P. Guidi <raffaele.p.guidi@gmail.com>:
> Well, being used to the github workflow this feels quite natural. The
> un-natural thing is asking before doing it (just fork, branch and make a
> pull request when you are done). In any case I think jira should be used to
> track bugs, ask for features and "assign" items, not to obtain an
> authorization to work on things. It shouldn't prevent spontaneous coding
> from committers.
>
> Ciao,
>   R
> Il giorno 26/nov/2011 07:55, "Tommaso Teofili" <tommaso.teofili@gmail.com>
> ha scritto:
>
>> Hi all,
>>
>> yesterday I was doing some code review on DM and my feeling is that we
>> should do some refactoring on a couple of things:
>>  - dependencies: I'd like to keep the dependency list size as low as
>> possible, trying to remove the dependencies that are not "critical" (i.e.:
>> I wouldn't rewrite a new logger slf4j just works nicely)
>>  - modularity: I think it'd be good if we could enhance cohesion and
>> modularity of classes; i.e. Cache and CacheService as they have lots of
>> different methods (different contracts / responsibilities)
>>
>> I know those are a kind of high level topics but I think I could try to
>> create a DM branch where I "propose" some dependencies to be removed and
>> also some code refactoring.
>> I'm proposing that instead of opening tinier issues/tasks on Jira since I
>> think changes would impact lots of classes so it may be hard to maintain.
>> What do you think?
>> Tommaso
>>
>



-- 
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy

Mime
View raw message