From depot-cvs-return-513-apmail-incubator-depot-cvs-archive=incubator.apache.org@incubator.apache.org Mon Jul 12 18:04:24 2004 Return-Path: Delivered-To: apmail-incubator-depot-cvs-archive@www.apache.org Received: (qmail 86175 invoked from network); 12 Jul 2004 18:04:24 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 12 Jul 2004 18:04:24 -0000 Received: (qmail 49967 invoked by uid 500); 12 Jul 2004 18:04:23 -0000 Delivered-To: apmail-incubator-depot-cvs-archive@incubator.apache.org Received: (qmail 49943 invoked by uid 500); 12 Jul 2004 18:04:23 -0000 Mailing-List: contact depot-cvs-help@incubator.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: depot-dev@incubator.apache.org Delivered-To: mailing list depot-cvs@incubator.apache.org Received: (qmail 49930 invoked by uid 99); 12 Jul 2004 18:04:23 -0000 X-ASF-Spam-Status: No, hits=0.5 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [209.237.227.194] (HELO minotaur.apache.org) (209.237.227.194) by apache.org (qpsmtpd/0.27.1) with SMTP; Mon, 12 Jul 2004 11:04:23 -0700 Received: (qmail 86156 invoked by uid 65534); 12 Jul 2004 18:04:22 -0000 Date: 12 Jul 2004 18:04:22 -0000 Message-ID: <20040712180422.86153.qmail@minotaur.apache.org> From: mmay@apache.org To: depot-cvs@incubator.apache.org Subject: svn commit: rev 22843 - incubator/depot/trunk/update/src/java/org/apache/depot/update/repository X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Author: mmay Date: Mon Jul 12 11:04:21 2004 New Revision: 22843 Modified: incubator/depot/trunk/update/src/java/org/apache/depot/update/repository/AbstractHierarchicalRepository.java Log: The method listArtifacts is pretty much useless, it uses an recursion, which equals an endless loop. Modified: incubator/depot/trunk/update/src/java/org/apache/depot/update/repository/AbstractHierarchicalRepository.java ============================================================================== --- incubator/depot/trunk/update/src/java/org/apache/depot/update/repository/AbstractHierarchicalRepository.java (original) +++ incubator/depot/trunk/update/src/java/org/apache/depot/update/repository/AbstractHierarchicalRepository.java Mon Jul 12 11:04:21 2004 @@ -115,6 +115,11 @@ setRepositoryAttribute(RepositoryAttribute.ACTIVE, Flag.TRUE); } + /** + * this method should not be called right now, it provides a dangerous recursion + * + * @deprecated this method is useless + */ public List listArtifacts( ArtifactUpdaterContext context, ArtifactGroup group, @@ -122,8 +127,10 @@ throws Exception { List results = null; + +// :TODO: useless recursion - calls the same method with the input parameters List artifacts = listArtifacts(context, group, selector); - + if (!artifacts.isEmpty()) { List unique = ComparisonHelper.sortUnique(