incubator-depot-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From m...@apache.org
Subject svn commit: rev 22843 - incubator/depot/trunk/update/src/java/org/apache/depot/update/repository
Date Mon, 12 Jul 2004 18:04:22 GMT
Author: mmay
Date: Mon Jul 12 11:04:21 2004
New Revision: 22843

Modified:
   incubator/depot/trunk/update/src/java/org/apache/depot/update/repository/AbstractHierarchicalRepository.java
Log:
The method listArtifacts is pretty much useless, it uses an
recursion, which equals an endless loop.

Modified: incubator/depot/trunk/update/src/java/org/apache/depot/update/repository/AbstractHierarchicalRepository.java
==============================================================================
--- incubator/depot/trunk/update/src/java/org/apache/depot/update/repository/AbstractHierarchicalRepository.java
(original)
+++ incubator/depot/trunk/update/src/java/org/apache/depot/update/repository/AbstractHierarchicalRepository.java
Mon Jul 12 11:04:21 2004
@@ -115,6 +115,11 @@
 		setRepositoryAttribute(RepositoryAttribute.ACTIVE, Flag.TRUE);
 	}
 
+	/**
+	 * this method should not be called right now, it provides a dangerous recursion
+	 * 
+	 * @deprecated this method is useless
+	 */
 	public List listArtifacts(
 		ArtifactUpdaterContext context,
 		ArtifactGroup group,
@@ -122,8 +127,10 @@
 		throws Exception {
 
 		List results = null;
+		
+// :TODO: useless recursion - calls the same method with the input parameters
 		List artifacts = listArtifacts(context, group, selector);
-
+		
 		if (!artifacts.isEmpty()) {
 			List unique =
 				ComparisonHelper.sortUnique(

Mime
View raw message