incubator-deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "marios@redhat.com" <mandr...@redhat.com>
Subject Re: [PATCH core 1/5] CIMI: Replaced elsif by case, switched block syntax
Date Wed, 16 Nov 2011 11:21:53 GMT
minor comment inline:

On 14/11/11 17:09, mfojtik@redhat.com wrote:
> From: Michal Fojtik <mfojtik@redhat.com>
> diff --git a/server/lib/cimi/model/base.rb b/server/lib/cimi/model/base.rb
> index 0ef2b27..de6529b 100644
> --- a/server/lib/cimi/model/base.rb
> +++ b/server/lib/cimi/model/base.rb
> @@ -163,7 +163,7 @@ class CIMI::Model::Base
>    text :uri, :name, :description, :created
>  
>    # FIXME: this doesn't match with JSON
> -  array :properties, :content => :value do
> -    scalar :key
> +  array :property, :content => :value do
> +    scalar :name

This was changed to :key and I think it makes more sense for it to be
:properties since it's meant to be a 'set of properties'.

JSON:  "properties": { "key": string, + }, ?
XML: <property key="xs:string"> xs:string </property> *

otherwise ACK

Mime
View raw message