incubator-deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "marios@redhat.com" <mandr...@redhat.com>
Subject Re: [PATCH core] Support: Modified init script to return proper status
Date Mon, 31 Oct 2011 15:16:34 GMT
ACK - conditionally ... (inline)

On 31/10/11 16:24, mfojtik@redhat.com wrote:
> From: Michal Fojtik <mfojtik@redhat.com>
> 
> 
> Signed-off-by: Michal fojtik <mfojtik@redhat.com>
> ---
>  server/support/fedora/deltacloud-core.init |   13 +++++++------
>  1 files changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/server/support/fedora/deltacloud-core.init b/server/support/fedora/deltacloud-core.init
> index 2b2fb56..ca1e1da 100755
> --- a/server/support/fedora/deltacloud-core.init
> +++ b/server/support/fedora/deltacloud-core.init
> @@ -7,13 +7,13 @@
>  
> +PIDFILE="${PIDFILE:-/var/run/deltacloud-core-$DRIVER.pid}"
>  
>  [ -r $LOGFILE ] && chown nobody $LOGFILE
>  [ -r $LOCKFILE ] && chown nobody $LOCKFILE
> @@ -47,7 +48,7 @@ start() {
>      # the process.  Note that for systemd, this has no real effect;
>      # systemd always starts initscripts with a clean environment and PWD of /
>      cd /
> -    daemon --user "$DELTACLOUD_USER" "$exec -i $DRIVER -e $API_ENV --port $PORT -r $HOST
>> $LOGFILE 2>&1 &"
> +    daemon --user "$DELTACLOUD_USER" "$exec -i $DRIVER -e $API_ENV --port $PORT -r $HOST
--pid $PIDFILE >> $LOGFILE 2>&1 &"

so this means that Thin::Runner will set the PID. Do we also need to
remove the PIDFILE for stop() or does thin do this for us?

marios


Mime
View raw message