incubator-deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Lalancette <clala...@redhat.com>
Subject Re: [PATCH] Use UUIDTools instead of UUID in condor driver
Date Thu, 29 Sep 2011 20:05:16 GMT
On 09/29/11 - 11:49:08AM, Ian Main wrote:
> This patch updates the condor driver to use UUIDTools as this already
> exists in fedora.  I also added the dependency to the gem list.  The RPM
> will have to be updated for this dependency as well.
> 
> Signed-off-by: Ian Main <imain@redhat.com>
> ---
>  server/deltacloud-core.gemspec                     |    1 +
>  .../lib/deltacloud/drivers/condor/condor_driver.rb |    4 ++--
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/server/deltacloud-core.gemspec b/server/deltacloud-core.gemspec
> index 1c06542..0fec7c6 100644
> --- a/server/deltacloud-core.gemspec
> +++ b/server/deltacloud-core.gemspec
> @@ -74,6 +74,7 @@ Gem::Specification.new do |s|
>    s.add_dependency('net-ssh', '>= 2.0.0')
>    s.add_dependency('thin', '>= 1.2.5')
>    s.add_dependency('nokogiri', '>= 1.4.3')
> +  s.add_dependency('uuidtools', '>= 2.1.1')

The code itself looks fine.

Slow and I talked on IRC, and agreed that the gemspec needs a comment stating
that it is a dependency for condor-cloud.  The dependency for rest-client also
needs to be updated to mention condor-cloud.

Finally, the RPM needs to be updated to re-enable condor-cloud now that the
dependency has been satisfied.  Therefore, I've committed this patch with some
tweaks.  The patch I pushed looks like the attached.

-- 
Chris Lalancette

Mime
View raw message