incubator-deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Lutterkort <lut...@redhat.com>
Subject Re: [PATCH core] Added XForms representation of XML new instance form
Date Fri, 16 Sep 2011 21:10:18 GMT
On Fri, 2011-09-16 at 11:33 +0200, mfojtik@redhat.com wrote:
> From: Michal Fojtik <mfojtik@redhat.com>
> 
> 
> Signed-off-by: Michal fojtik <mfojtik@redhat.com>

I like doing this a lot, though would like to hear from any API users if
XForms would be useful to them. Or, put differently, I would like to
make sure that what we report there is/can be used by a real-life
client.

Other than that, the patch looks good, with a couple small typos:

> diff --git a/server/views/instances/new.xml.haml b/server/views/instances/new.xml.haml
> new file mode 100644
> index 0000000..498dec2
> --- /dev/null
> +++ b/server/views/instances/new.xml.haml
> @@ -0,0 +1,99 @@
> +%xforms{ :'xmlns:xf' => "http://www.w3.org/2002/xforms", :'xmlns:xsd' => "http://www.w3.org/2001/XMLSchema",
:'xmlns:xsi' => "http://www.w3.org/2001/XMLSchema-instance"}
> +  %model
> +    %submission{ :id =>"new_instance", :method => "GET",  :action => create_instance_url
}

Shouldn't method be POST ?

> +    %instance
> +      %instance

One instance ought to be enough for anybody ;)

David



Mime
View raw message