Mailing-List: contact deltacloud-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: deltacloud-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of lutter@redhat.com designates
 209.132.183.28 as permitted sender)
Subject: Re: [PATCH core] Added support to daemonize Deltacloud and log to
 the syslog
From: David Lutterkort <lutter@redhat.com>
To: deltacloud-dev@incubator.apache.org
Date: Wed, 17 Aug 2011 17:20:34 -0700
In-Reply-To: <F3D1EF37-DB84-496D-8111-49417F4C4755@redhat.com>
References: <1313067834-55151-1-git-send-email-mfojtik@redhat.com>
	 <1313102321.3374.4.camel@melon.watzmann.net>
	 <43B70C39-BA4B-4ACE-9A34-FD70C39BB70B@redhat.com>
	 <1313452301.31805.14.camel@avon.watzmann.net>
	 <F3D1EF37-DB84-496D-8111-49417F4C4755@redhat.com>
Organization: Red Hat Inc
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: 7bit
Message-ID: <1313626834.31805.95.camel@avon.watzmann.net>
Mime-Version: 1.0

On Tue, 2011-08-16 at 10:51 +0200, Michal Fojtik wrote:
> On Aug 16, 2011, at 1:51 AM, David Lutterkort wrote:
> 
> > On Fri, 2011-08-12 at 10:42 +0200, Michal Fojtik wrote:
> >> On Aug 12, 2011, at 12:38 AM, David Lutterkort wrote:
> >> 
> >>> On Thu, 2011-08-11 at 15:03 +0200, mfojtik@redhat.com wrote:
> >>>> From: Michal Fojtik <mfojtik@redhat.com>
> >>>> 
> >>>> 
> >>>> Signed-off-by: Michal fojtik <mfojtik@redhat.com>
> >>>> ---
> >>>> server/NOTICE                                     |    3 +
> >>>> server/bin/deltacloudd                            |   38 ++++++---
> >>>> server/lib/deltacloud/base_driver/exceptions.rb   |   15 ++--
> >>>> server/lib/deltacloud/drivers/mock/mock_driver.rb |    2 +-
> >>>> server/lib/sinatra/body_proxy.rb                  |   34 ++++++++
> >>>> server/lib/sinatra/rack_syslog.rb                 |   91 +++++++++++++++++++++
> >>>> server/server.rb                                  |   11 ++-
> >>>> 7 files changed, 169 insertions(+), 25 deletions(-)
> >>>> create mode 100644 server/lib/sinatra/body_proxy.rb
> >>>> create mode 100644 server/lib/sinatra/rack_syslog.rb
> >>> 
> >>> This patch causes server startup for me to fail:
> >>> 
> >>>       melon:[14006] server>./bin/deltacloudd -i mock
> >>>       Starting Deltacloud API :: mock :: http://localhost:3001/api
> >>> 
> >>> 
> >>>       15:37:05 - Server Launched
> >>>       (__DELEGATE__):2:in `settings': stack level too deep (SystemStackError)
> >>>       	from (__DELEGATE__):2:in `send'
> >>>       	from (__DELEGATE__):2:in `settings'
> >>>       	from (__DELEGATE__):2:in `send'
> >>>       	from (__DELEGATE__):2:in `settings'
> >>>       	from (__DELEGATE__):2:in `send'
> >>>       	from (__DELEGATE__):2:in `settings'
> >>>       	from (__DELEGATE__):2:in `send'
> >>>       	from (__DELEGATE__):2:in `settings'
> >>>       	 ... 1577 levels...
> >>>       	from /homes/lutter/.gem/ruby/1.8/gems/rack-1.1.2/lib/rack/builder.rb:46:in `instance_eval'
> >>>       	from /homes/lutter/.gem/ruby/1.8/gems/rack-1.1.2/lib/rack/builder.rb:46:in `initialize'
> >>>       	from config.ru:1:in `new'
> >>>       	from config.ru:1
> >>> 
> >>>       15:37:07 - Server Launch Failed
> >> 
> >> Wow. I personally tested it before I sent the patch out. Could you try to update sinatra and rack?
> >> I'm using sinatra 1.2.6 and rack 1.3.0.
> > 
> > Aren't we getting ahead of ourselves there ? F15 is still on
> > rubygem-rack-1:1.1.0-2.fc14.noarch and
> > rubygem-thin-1.2.11-8.fc14.x86_64. Do we actually need these newer
> > versions or is that just what gem did ?
> 
> Those are versions you get when you use 'gem install' instead of RPM.
> I wanna test all those new gems before they are pushed to fedora, so
> we should be sure that DC will live with all those new version.

Ok .. I now went back to the rpm version of sinatra (1.1.2), and your
patch works. ACK

David