incubator-deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Lutterkort <lut...@redhat.com>
Subject Re: [PATCH core 4/5] RHEVM: Added create_image from instance
Date Fri, 05 Aug 2011 22:29:02 GMT
On Tue, 2011-08-02 at 15:29 +0200, mfojtik@redhat.com wrote:
> From: Michal Fojtik <mfojtik@redhat.com>
> 
> 
> Signed-off-by: Michal fojtik <mfojtik@redhat.com>
> ---
>  .../lib/deltacloud/drivers/rhevm/rhevm_client.rb   |   22 ++++++++++++++++++++
>  .../lib/deltacloud/drivers/rhevm/rhevm_driver.rb   |   21 ++++++++++++++++++-
>  2 files changed, 42 insertions(+), 1 deletions(-)

ACK
 
> @@ -299,6 +314,10 @@ class RHEVMDriver < Deltacloud::BaseDriver
>        status 500
>      end
>  
> +    on /ERROR:(.*)/ do
> +      status 500
> +    end
> +

Wouldn't 400 Bad request or 404 Not found be more appropriate ?

David



Mime
View raw message