incubator-deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "marios@redhat.com" <mandr...@redhat.com>
Subject Re: [PATCH] Remove what seems to be a pointless assignment.
Date Wed, 15 Jun 2011 15:02:37 GMT
for completeness, the patch *did* apply cleanly but only ontop of the 
previous one (i.e. this patch should have been applied ontop of "Remove 
EC2 instance tagging and load balancer registering."). I have pushed 
this and instace tagging onto trunk since Chris doesn't have commit 
rights yet (no idea what the delay on that is?)

marios

On 15/06/11 17:30, marios@redhat.com wrote:
> ack ... the patch obviously makes sense but I was not able to apply
> clean so just a reminder that you may need to rebase before push (sorry
> you likely do that already, "Chris <git_jitsuka_san> Lalancette")
>
> <snip>
>
> Applying: Remove what seems to be a pointless assignment.
> error: patch failed: server/lib/deltacloud/drivers/ec2/ec2_driver.rb:229
> error: server/lib/deltacloud/drivers/ec2/ec2_driver.rb: patch does not
> apply
> Patch failed at 0001 Remove what seems to be a pointless assignment.
>
> On 15/06/11 16:44, Chris Lalancette wrote:
>> Any reviews/ACKs on this?
>>
>> Thanks,
>


Mime
View raw message